Make DeviceOrientationEvent.prototype.absolute non-nullable

content/browser/device_sensors/sensor_manager_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/device_sensors/sensor_manager_android.h"
 
 #include <string.h>
 
 #include "base/android/context_utils.h"
 #include "base/android/jni_android.h"
@@ skipping 22 matching lines @@
   buffer->data.hasBeta = true;
   buffer->data.gamma = gamma;
   buffer->data.hasGamma = true;
   buffer->seqlock.WriteEnd();
 }
 
 void SetOrientationBufferStatus(
     content::DeviceOrientationHardwareBuffer* buffer,
     bool ready, bool absolute) {
   buffer->seqlock.WriteBegin();
   buffer->data.absolute = absolute;

[philipj_slow, 2016/02/26 03:54:01]

Should I make this absolute && ready, so that cases that were previously null
are now false instead? Does the spec offer any guidance and can you think of a
case where it matters?

[timvolodine, 2016/03/01 22:36:25]

the spec doesn't mention the value of absolute in case of all-null event for
example, however this is a helper method to set the values in the buffer so I
think we can keep it the way it is now.

[philipj_slow, 2016/03/02 07:30:42]

I looked at all the call sites, and it turns out that making this absolute &&
ready wouldn't actually change the resulting value in any case. I'll leave it
as-is.

-  buffer->data.hasAbsolute = ready;
   buffer->data.allAvailableSensorsAreActive = ready;
   buffer->seqlock.WriteEnd();
 }
 
 }  // namespace
 
 namespace content {
 
 SensorManagerAndroid::SensorManagerAndroid()
     : number_active_device_motion_sensors_(0),
@@ skipping 488 matching lines @@
     }
   }
 }
 
 void SensorManagerAndroid::Shutdown() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   is_shutdown_ = true;
 }
 
 }  // namespace content