chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feb -> March Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/exclusive_access/exclusive_access_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index b515194acba1aea5c4fb205751fa6489bc1ec73b..44da54d73b4a466c60931cfebbc60217b1ec708a 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -834,7 +834,7 @@ willPositionSheet:(NSWindow*)sheet

fullscreen_mac::SlidingStyle style;

if ([self isFullscreenForTabContent]) {

style = fullscreen_mac::OMNIBOX_TABS_NONE;

- } else if (enteringPresentationMode_ || [self shouldHideFullscreenToolbar]) {

+ } else if (enteringPresentationMode_ || ![self shouldShowFullscreenToolbar]) {

style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;

} else {

style = fullscreen_mac::OMNIBOX_TABS_PRESENT;