chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm - Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feb -> March Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

index 7865cef9cd1e971c704729430ac4dea0c073d46f..c92f2dce705bd1cbac062584ccdc088eb90963fd 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

@@ -697,9 +697,9 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,

if (!chrome::mac::SupportsSystemFullscreen())

return;

- // Tests that the preference is set to false by default.

+ // Tests that the preference is set to true by default.

PrefService* prefs = browser()->profile()->GetPrefs();

- EXPECT_FALSE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));

+ EXPECT_TRUE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));

// Toggle fullscreen and check if the toolbar is shown.

ToggleFullscreenAndWaitForNotification();

@@ -709,7 +709,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,

// is hidden and the preference is correctly updated.

[[controller() presentationModeController] setToolbarFraction:0.0];

chrome::ExecuteCommand(browser(), IDC_TOGGLE_FULLSCREEN_TOOLBAR);

- EXPECT_TRUE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));

+ EXPECT_FALSE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));

VerifyFullscreenToolbarVisibility(fullscreen_mac::OMNIBOX_TABS_HIDDEN);

// Toggle out and back into fullscreen and verify that the toolbar is still

@@ -719,5 +719,5 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,

VerifyFullscreenToolbarVisibility(fullscreen_mac::OMNIBOX_TABS_HIDDEN);

chrome::ExecuteCommand(browser(), IDC_TOGGLE_FULLSCREEN_TOOLBAR);

- EXPECT_FALSE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));

+ EXPECT_TRUE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));

}