Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4692)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feb -> March Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 8bbb544bc26f29f93c0716fefe79259af188a5e6..bf0d06942dcbad29440916973b625972a7c20483 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -438,9 +438,8 @@ void SetUpBrowserWindowCommandHandler(NSWindow* window) {
windowShim_.get()));
PrefService* prefs = browser_->profile()->GetPrefs();
- shouldHideFullscreenToolbar_ =
- prefs->GetBoolean(prefs::kHideFullscreenToolbar);
-
+ shouldShowFullscreenToolbar_ =
+ prefs->GetBoolean(prefs::kShowFullscreenToolbar);
blockLayoutSubviews_ = NO;
// We are done initializing now.
@@ -1991,14 +1990,14 @@ willAnimateFromState:(BookmarkBar::State)oldState
return NO;
}
-- (void)setFullscreenToolbarHidden:(BOOL)shouldHide {
- if (shouldHideFullscreenToolbar_ == shouldHide)
+- (void)setFullscreenToolbarVisible:(BOOL)visible {
+ if (shouldShowFullscreenToolbar_ == visible)
return;
[presentationModeController_ setToolbarFraction:0.0];
- shouldHideFullscreenToolbar_ = shouldHide;
+ shouldShowFullscreenToolbar_ = visible;
if ([self isInAppKitFullscreen])
- [self updateFullscreenWithToolbar:!shouldHideFullscreenToolbar_];
+ [self updateFullscreenWithToolbar:shouldShowFullscreenToolbar_];
}
- (BOOL)isInAnyFullscreenMode {
@@ -2061,8 +2060,8 @@ willAnimateFromState:(BookmarkBar::State)oldState
fullscreen_mac::OMNIBOX_TABS_HIDDEN;
}
-- (BOOL)shouldHideFullscreenToolbar {
- return shouldHideFullscreenToolbar_;
+- (BOOL)shouldShowFullscreenToolbar {
+ return shouldShowFullscreenToolbar_;
}
- (void)resizeFullscreenWindow {
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698