Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8199)

Unified Diff: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feb -> March Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
diff --git a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
index e2a8ed0ede86f8407ec191893ec5a4e0662515b0..3873c467d35ff5c847e9c4721505e27b49275b21 100644
--- a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
+++ b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
@@ -22,7 +22,13 @@ ExclusiveAccessController::ExclusiveAccessController(
Browser* browser)
: controller_(controller),
browser_(browser),
- bubble_type_(EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) {}
+ bubble_type_(EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) {
+ pref_registrar_.Init(GetProfile()->GetPrefs());
+ pref_registrar_.Add(
+ prefs::kShowFullscreenToolbar,
+ base::Bind(&ExclusiveAccessController::UpdateFullscreenToolbar,
+ base::Unretained(this)));
+}
ExclusiveAccessController::~ExclusiveAccessController() {}
@@ -73,11 +79,10 @@ void ExclusiveAccessController::UpdateFullscreenWithToolbar(bool with_toolbar) {
[controller_ updateFullscreenWithToolbar:with_toolbar];
}
-void ExclusiveAccessController::ToggleFullscreenToolbar() {
- PrefService* prefs = browser_->profile()->GetPrefs();
- bool hideToolbar = !prefs->GetBoolean(prefs::kHideFullscreenToolbar);
- [controller_ setFullscreenToolbarHidden:hideToolbar];
- prefs->SetBoolean(prefs::kHideFullscreenToolbar, hideToolbar);
+void ExclusiveAccessController::UpdateFullscreenToolbar() {
+ PrefService* prefs = GetProfile()->GetPrefs();
+ bool showToolbar = prefs->GetBoolean(prefs::kShowFullscreenToolbar);
+ [controller_ setFullscreenToolbarVisible:showToolbar];
}
bool ExclusiveAccessController::IsFullscreenWithToolbar() const {

Powered by Google App Engine
This is Rietveld 408576698