Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3198)

Unified Diff: chrome/browser/ui/browser_commands_mac.cc

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feb -> March Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands_mac.cc
diff --git a/chrome/browser/ui/browser_commands_mac.cc b/chrome/browser/ui/browser_commands_mac.cc
index b6fb858b044b48dcdd79ae225c9c0afc782b0cdd..d286aa95e14cc20b449bece65804b022e683558d 100644
--- a/chrome/browser/ui/browser_commands_mac.cc
+++ b/chrome/browser/ui/browser_commands_mac.cc
@@ -4,19 +4,19 @@
#include "chrome/browser/ui/browser_commands_mac.h"
-#include "base/command_line.h"
#include "chrome/browser/fullscreen.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
-#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
-#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "components/prefs/pref_service.h"
namespace chrome {
void ToggleFullscreenWithToolbarOrFallback(Browser* browser) {
DCHECK(browser);
- if (chrome::mac::SupportsSystemFullscreen())
+ if (mac::SupportsSystemFullscreen())
browser->exclusive_access_manager()
->fullscreen_controller()
->ToggleBrowserFullscreenWithToolbar();
@@ -26,7 +26,11 @@ void ToggleFullscreenWithToolbarOrFallback(Browser* browser) {
void ToggleFullscreenToolbar(Browser* browser) {
DCHECK(browser);
- browser->exclusive_access_manager()->context()->ToggleFullscreenToolbar();
+
+ // Toggle the value of the preference.
+ PrefService* prefs = browser->profile()->GetPrefs();
+ bool show_toolbar = prefs->GetBoolean(prefs::kShowFullscreenToolbar);
+ prefs->SetBoolean(prefs::kShowFullscreenToolbar, !show_toolbar);
}
} // namespace chrome
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698