Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 1737413002: Modified the behavior of "Hide Toolbar in Full Screen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index 7865cef9cd1e971c704729430ac4dea0c073d46f..9ffe9ab15af5312df91c9acbaa9069841e0fe38a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -699,7 +699,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
// Tests that the preference is set to false by default.
msw 2016/03/01 00:07:15 nit: update comment
spqchan 2016/03/01 17:50:18 Done.
PrefService* prefs = browser()->profile()->GetPrefs();
- EXPECT_FALSE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));
+ EXPECT_TRUE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));
// Toggle fullscreen and check if the toolbar is shown.
ToggleFullscreenAndWaitForNotification();
@@ -709,7 +709,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
// is hidden and the preference is correctly updated.
[[controller() presentationModeController] setToolbarFraction:0.0];
chrome::ExecuteCommand(browser(), IDC_TOGGLE_FULLSCREEN_TOOLBAR);
- EXPECT_TRUE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));
+ EXPECT_FALSE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));
VerifyFullscreenToolbarVisibility(fullscreen_mac::OMNIBOX_TABS_HIDDEN);
// Toggle out and back into fullscreen and verify that the toolbar is still
@@ -719,5 +719,5 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
VerifyFullscreenToolbarVisibility(fullscreen_mac::OMNIBOX_TABS_HIDDEN);
chrome::ExecuteCommand(browser(), IDC_TOGGLE_FULLSCREEN_TOOLBAR);
- EXPECT_FALSE(prefs->GetBoolean(prefs::kHideFullscreenToolbar));
+ EXPECT_TRUE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));
}

Powered by Google App Engine
This is Rietveld 408576698