Modified the behavior of "Hide Toolbar in Full Screen"

chrome/browser/ui/cocoa/browser_window_command_handler.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_command_handler.h"
 
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #include "chrome/app/chrome_command_ids.h"
 #import "chrome/browser/app_controller_mac.h"
@@ skipping 37 matching lines @@
 
   // On Windows this logic happens in bookmark_bar_view.cc. This simply updates
   // the menu item; it does not display the bookmark bar itself.
   if (tag == IDC_SHOW_BOOKMARK_BAR) {
     SetToggleState(browser->window()->IsBookmarkBarVisible(), item);
     return;
   }
 
   if (tag == IDC_TOGGLE_FULLSCREEN_TOOLBAR) {
     PrefService* prefs = browser->profile()->GetPrefs();
-    SetToggleState(prefs->GetBoolean(prefs::kHideFullscreenToolbar), item);
+
+    // Migrate the value of kHideFullscreenToolbar to kShowFullscreenToolbar if

[msw, 2016/03/01 00:08:51]

Do we only migrate when the user toggles the value? that doesn't seem right...

[spqchan, 2016/03/01 17:50:18]

No, this is called when the menu is created. The method is called to make sure
that the checkmark state of the menu items are set correctly. You're right
though, it makes more sense for this to be migrated when the browser is created,
not when the menu is created. Moved it to browser.cc

+    // it was set by the user. See crbug.com/590827.
+    const PrefService::Preference* hide_pref =
+        prefs->FindPreference(prefs::kHideFullscreenToolbar);
+    if (!hide_pref->IsDefaultValue()) {
+      bool hide_pref_value = prefs->GetBoolean(prefs::kHideFullscreenToolbar);
+      prefs->SetBoolean(prefs::kShowFullscreenToolbar, !hide_pref_value);
+      prefs->ClearPref(prefs::kHideFullscreenToolbar);
+    }
+
+    SetToggleState(prefs->GetBoolean(prefs::kShowFullscreenToolbar), item);
     return;
   }
 
   // Update the checked/unchecked state of items in the encoding menu.
   // On Windows, this logic is part of |EncodingMenuModel| in
   // browser/ui/views/toolbar_view.h.
   EncodingMenuController encoding_controller;
   if (!encoding_controller.DoesCommandBelongToEncodingMenu(tag))
     return;
 
@@ skipping 205 matching lines @@
     // the background" in this case.
     modifierFlags &= ~NSCommandKeyMask;
   }
   chrome::ExecuteCommandWithDisposition(
       FindBrowserForSender(sender, window), command,
       ui::WindowOpenDispositionFromNSEventWithFlags([NSApp currentEvent],
                                                     modifierFlags));
 }
 
 @end