Modified the behavior of "Hide Toolbar in Full Screen"

chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h"
 
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/fullscreen.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/accelerators_cocoa.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
 #include "chrome/browser/ui/status_bubble.h"
 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
 #include "chrome/common/pref_names.h"
 #include "components/prefs/pref_service.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
 
 ExclusiveAccessController::ExclusiveAccessController(
     BrowserWindowController* controller,
     Browser* browser)
     : controller_(controller),
       browser_(browser),
-      bubble_type_(EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) {}
+      bubble_type_(EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) {
+  pref_registrar_.Init(GetProfile()->GetPrefs());
+  pref_registrar_.Add(
+      prefs::kShowFullscreenToolbar,
+      base::Bind(&ExclusiveAccessController::UpdateFullscreenToolbar,
+                 base::Unretained(this)));
+}
 
 ExclusiveAccessController::~ExclusiveAccessController() {}
 
 void ExclusiveAccessController::Show() {
   if (ExclusiveAccessManager::IsSimplifiedFullscreenUIEnabled()) {
     views_bubble_.reset(
         new ExclusiveAccessBubbleViews(this, url_, bubble_type_));
     return;
   }
 
@@ skipping 30 matching lines @@
 }
 
 bool ExclusiveAccessController::SupportsFullscreenWithToolbar() const {
   return chrome::mac::SupportsSystemFullscreen();
 }
 
 void ExclusiveAccessController::UpdateFullscreenWithToolbar(bool with_toolbar) {
   [controller_ updateFullscreenWithToolbar:with_toolbar];
 }
 
-void ExclusiveAccessController::ToggleFullscreenToolbar() {
-  PrefService* prefs = browser_->profile()->GetPrefs();
-  bool hideToolbar = !prefs->GetBoolean(prefs::kHideFullscreenToolbar);
+void ExclusiveAccessController::UpdateFullscreenToolbar() {
+  PrefService* prefs = GetProfile()->GetPrefs();
+  bool hideToolbar = !prefs->GetBoolean(prefs::kShowFullscreenToolbar);

[msw, 2016/03/01 00:07:15]

This inversion seems correct, but the old logic also had an inversion for the
old pref; I'm confused, can you clarify?

[spqchan, 2016/03/01 17:50:18]

Sorry for the confusion, the old logic was different because it was in charge of
toggling the preference.
As such, it would get the value, invert it, set the toolbar in the window
according to it and then change the preference to the new value.

The new logic will only retrieves the variable and update the toolbar.
Since it no longer need to toggle the variable, there's no need to invert it.

Anyway, I just tried to make things a bit more clear by changing "hideToolbar"
to "showToolbar" in the BrowserWindowController.

   [controller_ setFullscreenToolbarHidden:hideToolbar];
-  prefs->SetBoolean(prefs::kHideFullscreenToolbar, hideToolbar);
 }
 
 bool ExclusiveAccessController::IsFullscreenWithToolbar() const {
   return IsFullscreen() && ![controller_ inPresentationMode];
 }
 
 // See the Fullscreen terminology section and the (Fullscreen) interface
 // category in browser_window_controller.h for a detailed explanation of the
 // logic in this method.
 void ExclusiveAccessController::EnterFullscreen(
@@ skipping 85 matching lines @@
 }
 
 gfx::Rect ExclusiveAccessController::GetTopContainerBoundsInScreen() {
   NOTREACHED();  // Only used for ImmersiveMode.
   return gfx::Rect();
 }
 
 BrowserWindow* ExclusiveAccessController::GetBrowserWindow() const {
   return [controller_ browserWindow];
 }