Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1737383002: remove xmlparser includes from samples (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 9 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove xmlparser includes from samples Remove all #include SkXMLParser.h from SampleApp samples. R=tomhudson@google.com BUG=skia:309 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737383002 Committed: https://skia.googlesource.com/skia/+/9ae14ff4b1100aad8fe9402080a5ecb5a629f815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M samplecode/SampleHairline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleLines.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePictFile.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SamplePoints.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737383002/1
4 years, 10 months ago (2016-02-25 22:18:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 22:30:55 UTC) #5
caryclark
4 years, 10 months ago (2016-02-26 12:44:51 UTC) #6
tomhudson
lgtm
4 years, 9 months ago (2016-02-29 17:04:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737383002/1
4 years, 9 months ago (2016-02-29 17:04:28 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 17:13:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ae14ff4b1100aad8fe9402080a5ecb5a629f815

Powered by Google App Engine
This is Rietveld 408576698