Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1737373002: Revert of Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@retract-pipeline
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder (patchset #3 id:40001 of https://codereview.chromium.org/1730903007/ ) Reason for revert: Got a GL-related crash in nanobench: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release/builds/3815/steps/nanobench/logs/stdio Given we're about to branch and this is the only GL-related change in the blamelist, I'm going to assume this is responsible and revert. Original issue's description: > Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder > > Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. > > TBR=bsalomon@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730903007 > > Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf TBR=joshualitt@chromium.org,bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d2c77912339410fd24b21331b6703b1929919401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -73 lines) Patch
M include/gpu/GrDrawContext.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 20 chunks +70 lines, -68 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ethannicholas
Created Revert of Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder
4 years, 10 months ago (2016-02-25 21:43:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737373002/1
4 years, 10 months ago (2016-02-25 21:43:10 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 21:43:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d2c77912339410fd24b21331b6703b1929919401

Powered by Google App Engine
This is Rietveld 408576698