Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: build/coverage_wrapper.py

Issue 1737263003: [coverage] Enable sanitizer coverage. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review Andrii Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/standalone.gypi » ('j') | tools/sanitizers/sancov_formatter.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/coverage_wrapper.py
diff --git a/build/coverage_wrapper.py b/build/coverage_wrapper.py
index c1db754c94c1b4c323bda1551f482d007dc0fb50..7cb91259621af153c33463270acead0e588a3dc0 100755
--- a/build/coverage_wrapper.py
+++ b/build/coverage_wrapper.py
@@ -11,18 +11,28 @@ import subprocess
import sys
exclusions = [
+ 'buildtools',
'src/third_party',
'third_party',
'test',
'testing',
]
+def remove_if_exists(string_list, item):
+ try:
kjellander_chromium 2016/03/08 04:48:33 I guess it's faster to do if item in string_list:
Michael Achenbach 2016/03/08 10:05:46 Done. Your way is definitely more readable and I d
tandrii(chromium) 2016/03/08 14:48:57 Your honor, I object! First, try .. except ValueE
Michael Achenbach 2016/03/08 14:53:59 Right. Either way, I think it's hardly measurable
+ string_list.remove(item)
+ except:
+ pass
+
args = sys.argv[1:]
text = ' '.join(sys.argv[2:])
for exclusion in exclusions:
if re.search(r'\-o obj/%s[^ ]*\.o' % exclusion, text):
- args.remove('-fprofile-arcs')
- args.remove('-ftest-coverage')
+ remove_if_exists(args, '-fprofile-arcs')
+ remove_if_exists(args, '-ftest-coverage')
+ remove_if_exists(args, '-fsanitize-coverage=func')
+ remove_if_exists(args, '-fsanitize-coverage=bb')
+ remove_if_exists(args, '-fsanitize-coverage=edge')
break
sys.exit(subprocess.check_call(args))
« no previous file with comments | « no previous file | build/standalone.gypi » ('j') | tools/sanitizers/sancov_formatter.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698