content/renderer/media/webmediaplayer_ms.cc - Issue 1737253002: Handle Alpha channel in Canvas capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 1737253002: Handle Alpha channel in Canvas capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bbudge@ nit. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_ms.cc

diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc

index 0a726303f6640949930e6f0788f2ffe240cee00b..edf0083f3a23fa94ebd7603126fd31dbc692c56e 100644

--- a/content/renderer/media/webmediaplayer_ms.cc

+++ b/content/renderer/media/webmediaplayer_ms.cc

@@ -495,7 +495,7 @@ void WebMediaPlayerMS::OnFrameAvailable(

video_weblayer_.reset(new cc_blink::WebLayerImpl(

cc::VideoLayer::Create(cc::LayerSettings(),

compositor_.get(), media::VIDEO_ROTATION_0)));

- video_weblayer_->layer()->SetContentsOpaque(true);

+ video_weblayer_->layer()->SetContentsOpaque(false);

video_weblayer_->SetContentsOpaqueIsFixed(true);

get_client()->setWebLayer(video_weblayer_.get());

}