Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8385)

Unified Diff: chrome/renderer/media/cast_session_delegate.h

Issue 173713004: Cast: Plumb raw event logs to cast extension, install EncodingEventSubscriber on CastSessionDelegat… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix subscriber leak Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/media/cast_session.cc ('k') | chrome/renderer/media/cast_session_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/media/cast_session_delegate.h
diff --git a/chrome/renderer/media/cast_session_delegate.h b/chrome/renderer/media/cast_session_delegate.h
index 1dc6e960f2d53a0e7dec9bdb055cb4dbd21f6601..70c11e8d75ef149c6d9ef90e4460150d14c848fe 100644
--- a/chrome/renderer/media/cast_session_delegate.h
+++ b/chrome/renderer/media/cast_session_delegate.h
@@ -24,6 +24,7 @@ class VideoFrame;
namespace cast {
class CastEnvironment;
+class EncodingEventSubscriber;
class FrameInput;
namespace transport {
@@ -40,6 +41,7 @@ class CastSessionDelegate {
public:
typedef base::Callback<void(const scoped_refptr<media::cast::FrameInput>&)>
FrameInputAvailableCallback;
+ typedef base::Callback<void(scoped_ptr<std::string>)> EventLogsCallback;
CastSessionDelegate();
virtual ~CastSessionDelegate();
@@ -56,6 +58,9 @@ class CastSessionDelegate {
void StartUDP(const net::IPEndPoint& local_endpoint,
const net::IPEndPoint& remote_endpoint);
+ // Returns raw event logs in serialized format since last call.
+ void GetEventLogsAndReset(const EventLogsCallback& callback);
+
protected:
// Callback with the result of the initialization.
// If this callback is called with STATUS_INITIALIZED it will report back
@@ -92,6 +97,9 @@ class CastSessionDelegate {
FrameInputAvailableCallback audio_frame_input_available_callback_;
FrameInputAvailableCallback video_frame_input_available_callback_;
+ scoped_ptr<media::cast::EncodingEventSubscriber> audio_event_subscriber_;
+ scoped_ptr<media::cast::EncodingEventSubscriber> video_event_subscriber_;
+
net::IPEndPoint local_endpoint_;
net::IPEndPoint remote_endpoint_;
bool transport_configured_;
« no previous file with comments | « chrome/renderer/media/cast_session.cc ('k') | chrome/renderer/media/cast_session_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698