Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 173713004: Cast: Plumb raw event logs to cast extension, install EncodingEventSubscriber on CastSessionDelegat… (Closed)

Created:
6 years, 10 months ago by imcheng
Modified:
6 years, 10 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Plumb raw event logs up to CastSession, install EncodingEventSubscriber on CastSessionDelegate. CastSessionDelegate will have one or two EncodingEventSubscribers listening to audio / video events respectively. These subscribers are created alongside the CastSender / CastTransportSender. Next CL will be adding a JS API and a function in CastStreamingNativeHandler to get logs from CastSession. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252813

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : addressed alpha's comments #

Patch Set 5 : Add gyp dependency and try again #

Patch Set 6 : Rebase and try again #

Patch Set 7 : Fix subscriber leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M chrome/chrome_renderer.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/cast_session.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_session.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.h View 1 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 1 2 3 4 5 6 5 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
imcheng
I was debating whether to put the subscribers in CastRtpStream, CastSessionDelegate, or CastSenderImpl. It doesn't ...
6 years, 10 months ago (2014-02-20 23:04:27 UTC) #1
Alpha Left Google
On 2014/02/20 23:04:27, imcheng1 wrote: > I was debating whether to put the subscribers in ...
6 years, 10 months ago (2014-02-20 23:31:27 UTC) #2
imcheng
I think you're right. Logging should probably live alongside transport and the overall sender. I ...
6 years, 10 months ago (2014-02-21 00:44:32 UTC) #3
Alpha Left Google
LGTM with nits. https://codereview.chromium.org/173713004/diff/60001/chrome/renderer/media/cast_session_delegate.cc File chrome/renderer/media/cast_session_delegate.cc (right): https://codereview.chromium.org/173713004/diff/60001/chrome/renderer/media/cast_session_delegate.cc#newcode154 chrome/renderer/media/cast_session_delegate.cc:154: // Currently on main thread, can ...
6 years, 10 months ago (2014-02-21 01:59:19 UTC) #4
imcheng
+scherkus for review. https://codereview.chromium.org/173713004/diff/60001/chrome/renderer/media/cast_session_delegate.cc File chrome/renderer/media/cast_session_delegate.cc (right): https://codereview.chromium.org/173713004/diff/60001/chrome/renderer/media/cast_session_delegate.cc#newcode154 chrome/renderer/media/cast_session_delegate.cc:154: // Currently on main thread, can ...
6 years, 10 months ago (2014-02-21 03:17:25 UTC) #5
scherkus (not reviewing)
lgtm
6 years, 10 months ago (2014-02-21 15:59:02 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 18:33:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/110001
6 years, 10 months ago (2014-02-21 18:33:30 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:49:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-21 18:49:08 UTC) #10
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 19:02:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/340001
6 years, 10 months ago (2014-02-21 19:03:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/340001
6 years, 10 months ago (2014-02-21 19:16:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 19:48:11 UTC) #14
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=126687
6 years, 10 months ago (2014-02-21 19:48:11 UTC) #15
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 19:50:47 UTC) #16
imcheng
The CQ bit was unchecked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 19:52:02 UTC) #17
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 19:59:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/430003
6 years, 10 months ago (2014-02-21 20:00:57 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 21:54:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-21 21:54:41 UTC) #21
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 23:43:44 UTC) #22
imcheng
The CQ bit was unchecked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 23:44:14 UTC) #23
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-21 23:47:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/790001
6 years, 10 months ago (2014-02-21 23:47:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/790001
6 years, 10 months ago (2014-02-22 01:27:52 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 03:52:40 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268423
6 years, 10 months ago (2014-02-22 03:52:41 UTC) #28
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-22 04:57:25 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/790001
6 years, 10 months ago (2014-02-22 04:57:41 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 08:30:19 UTC) #31
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268468
6 years, 10 months ago (2014-02-22 08:30:20 UTC) #32
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-22 12:41:50 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/173713004/790001
6 years, 10 months ago (2014-02-22 12:42:00 UTC) #34
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 19:03:22 UTC) #35
Message was sent while issue was closed.
Change committed as 252813

Powered by Google App Engine
This is Rietveld 408576698