Issue 17370002: Implement InputMethodTSF

Issue 17370002: Implement InputMethodTSF (Closed)

Created:
7 years, 6 months ago by Yohei Yukawa

Modified:
7 years, 6 months ago

Reviewers:
Yohei Yukawa, Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, kochi, yoichio, Yuki

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Implement InputMethodTSF. This is the initial implementation of InputMethodTSF for Aura and non-Aura environment. BUG=239690, 246534 TEST=Tested with GoogleJapaneseInput Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207018

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comment #

Patch Set 3 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -13 lines)			Patch
	M	ui/base/ime/input_method_tsf.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	ui/base/ime/input_method_tsf.cc	View	1	2 chunks	+55 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

https://codereview.chromium.org/17370002/diff/1/ui/base/ime/input_method_tsf.cc File ui/base/ime/input_method_tsf.cc (right): https://codereview.chromium.org/17370002/diff/1/ui/base/ime/input_method_tsf.cc#newcode74 ui/base/ime/input_method_tsf.cc:74: const_cast<TextInputClient*>(client)); Is there any chance to remove const_cast? https://codereview.chromium.org/17370002/diff/1/ui/base/ime/input_method_tsf.cc#newcode80 ...

7 years, 6 months ago (2013-06-18 05:22:58 UTC) #2

Yohei Yukawa

https://codereview.chromium.org/17370002/diff/1/ui/base/ime/input_method_tsf.cc File ui/base/ime/input_method_tsf.cc (right): https://codereview.chromium.org/17370002/diff/1/ui/base/ime/input_method_tsf.cc#newcode74 ui/base/ime/input_method_tsf.cc:74: const_cast<TextInputClient*>(client)); On 2013/06/18 05:22:59, Seigo Nonaka wrote: > Is ...

7 years, 6 months ago (2013-06-18 05:53:31 UTC) #3

Seigo Nonaka

lgtm, but please make sure the all trybots go green :)

7 years, 6 months ago (2013-06-18 05:55:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/17370002/19001

7 years, 6 months ago (2013-06-18 14:19:02 UTC) #5

Message was sent while issue was closed.

Change committed as 207018

Expand Messages | Collapse Messages