Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1736893002: Update drag images to paint from the nearest self painting layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a performance note and prepare this ship for landing. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 6881 matching lines...) Expand 10 before | Expand all | Expand 10 after
6892 SkCanvas canvas(bitmap); 6892 SkCanvas canvas(bitmap);
6893 canvas.drawColor(SK_ColorGREEN); 6893 canvas.drawColor(SK_ColorGREEN);
6894 6894
6895 EXPECT_EQ(referenceBitmapSize.width(), dragImage->size().width()); 6895 EXPECT_EQ(referenceBitmapSize.width(), dragImage->size().width());
6896 EXPECT_EQ(referenceBitmapSize.height(), dragImage->size().height()); 6896 EXPECT_EQ(referenceBitmapSize.height(), dragImage->size().height());
6897 const SkBitmap& dragBitmap = dragImage->bitmap(); 6897 const SkBitmap& dragBitmap = dragImage->bitmap();
6898 SkAutoLockPixels lockPixel(dragBitmap); 6898 SkAutoLockPixels lockPixel(dragBitmap);
6899 EXPECT_EQ(0, memcmp(bitmap.getPixels(), dragBitmap.getPixels(), bitmap.getSi ze())); 6899 EXPECT_EQ(0, memcmp(bitmap.getPixels(), dragBitmap.getPixels(), bitmap.getSi ze()));
6900 } 6900 }
6901 6901
6902 TEST_P(ParameterizedWebFrameTest, NodeImageTestCSSTransformDescendant)
6903 {
6904 FrameTestHelpers::WebViewHelper webViewHelper(this);
6905 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-css-3dtransform-descendant"));
6906 EXPECT_TRUE(dragImage);
6907
6908 nodeImageTestValidation(IntSize(40, 40), dragImage.get());
6909 }
6910
6902 TEST_P(ParameterizedWebFrameTest, NodeImageTestCSSTransform) 6911 TEST_P(ParameterizedWebFrameTest, NodeImageTestCSSTransform)
6903 { 6912 {
6904 FrameTestHelpers::WebViewHelper webViewHelper(this); 6913 FrameTestHelpers::WebViewHelper webViewHelper(this);
6905 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-css-transform")); 6914 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-css-transform"));
6906 EXPECT_TRUE(dragImage); 6915 EXPECT_TRUE(dragImage);
6907 6916
6908 nodeImageTestValidation(IntSize(40, 40), dragImage.get()); 6917 nodeImageTestValidation(IntSize(40, 40), dragImage.get());
6909 } 6918 }
6910 6919
6911 TEST_P(ParameterizedWebFrameTest, NodeImageTestCSS3DTransform) 6920 TEST_P(ParameterizedWebFrameTest, NodeImageTestCSS3DTransform)
6912 { 6921 {
6913 FrameTestHelpers::WebViewHelper webViewHelper(this); 6922 FrameTestHelpers::WebViewHelper webViewHelper(this);
6914 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-css-3dtransform")); 6923 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-css-3dtransform"));
6915 EXPECT_TRUE(dragImage); 6924 EXPECT_TRUE(dragImage);
6916 6925
6917 nodeImageTestValidation(IntSize(20, 40), dragImage.get()); 6926 nodeImageTestValidation(IntSize(40, 40), dragImage.get());
6918 } 6927 }
6919 6928
6920 TEST_P(ParameterizedWebFrameTest, NodeImageTestInlineBlock) 6929 TEST_P(ParameterizedWebFrameTest, NodeImageTestInlineBlock)
6921 { 6930 {
6922 FrameTestHelpers::WebViewHelper webViewHelper(this); 6931 FrameTestHelpers::WebViewHelper webViewHelper(this);
6923 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-inlineblock")); 6932 OwnPtr<DragImage> dragImage = nodeImageTestSetup(&webViewHelper, std::string ("case-inlineblock"));
6924 EXPECT_TRUE(dragImage); 6933 EXPECT_TRUE(dragImage);
6925 6934
6926 nodeImageTestValidation(IntSize(40, 40), dragImage.get()); 6935 nodeImageTestValidation(IntSize(40, 40), dragImage.get());
6927 } 6936 }
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
8519 } 8528 }
8520 8529
8521 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange) 8530 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange)
8522 { 8531 {
8523 swapLocalFrameToRemoteFrame(); 8532 swapLocalFrameToRemoteFrame();
8524 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';")); 8533 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';"));
8525 EXPECT_FALSE(remoteFrameClient()->isVisible()); 8534 EXPECT_FALSE(remoteFrameClient()->isVisible());
8526 } 8535 }
8527 8536
8528 } // namespace blink 8537 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/web/tests/data/nodeimage.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698