Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1736883002: Ozone: Fix egl surface type for gbm_surfaceless (Closed)

Created:
4 years, 9 months ago by marcheu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone: Fix egl surface type for gbm_surfaceless Surfaceless doesn't create any window, so setting EGL_SURFACE_TYPE to EGL_WINDOW_BIT isn't really useful. It also fails on nvidia drivers. So, let's replace it with EGL_DONT_CARE. BUG=chromium:478339 TEST=boot on samus Committed: https://crrev.com/1ee7fcae18831439e4b9c8e709ad6d96b873c136 Cr-Commit-Position: refs/heads/master@{#377618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
marcheu
4 years, 9 months ago (2016-02-25 04:19:57 UTC) #3
alexst (slow to review)
lgtm
4 years, 9 months ago (2016-02-25 13:15:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736883002/1
4 years, 9 months ago (2016-02-25 17:42:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-25 18:23:17 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 18:24:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ee7fcae18831439e4b9c8e709ad6d96b873c136
Cr-Commit-Position: refs/heads/master@{#377618}

Powered by Google App Engine
This is Rietveld 408576698