Cleanup CSSPropertyParser

Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780
Committed: https://crrev.com/32a3bf47ecd8565d97f1f08597d165c008fe4d30
Cr-Commit-Position: refs/heads/master@{#380113}

[rwlbuis, 2016-03-09 00:29:57]

Description was changed from

==========
legacy css parser cleanup


Bar


Move background related shorthands into CSSPropertyParser

Move the following background related shorthands from
LegacyCSSPropertyParser into CSSPropertyParser:

background-repeat, background-position,
-webkit-mask-repeat, -webkit-mask-position

BUG=499780

patch from issue 1715513002 at patchset 60001
(http://crrev.com/1715513002#ps60001)
==========

to

==========
legacy css parser cleanup

BUG=499780
==========

[rwlbuis, 2016-03-09 03:20:54]

Description was changed from

==========
legacy css parser cleanup

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also make isGeneratedImage a static
helper method in CSSPropertyParser.cpp.

BUG=499780
==========

[rwlbuis, 2016-03-09 03:21:48]

Description was changed from

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also make isGeneratedImage a static
helper method in CSSPropertyParser.cpp.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780
==========

[rwlbuis, 2016-03-09 03:24:19]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-03-09 03:24:20]

PTAL.

I'll have a look how much work is left remaining for the grid properties to be
ported, or did you already have a look?

[Timothy Loh, 2016-03-09 03:52:41]

lgtm

On 2016/03/09 03:24:20, rwlbuis wrote:
> PTAL.
> 
> I'll have a look how much work is left remaining for the grid properties to be
> ported, or did you already have a look?

I haven't looked yet.

[rwlbuis, 2016-03-09 09:24:51]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-09 09:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736763003/40001

[commit-bot: I haz the power, 2016-03-09 10:34:34]

Description was changed from

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780
==========

[commit-bot: I haz the power, 2016-03-09 10:34:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-09 10:35:26]

Description was changed from

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780
==========

to

==========
Cleanup CSSPropertyParser

Remove a large number of methods from the legacy CSSPropertyParser
that are not used anymore. Also move isGeneratedImage and
createCSSImageValueWithReferrer into CSSPropertyParser.cpp.

BUG=499780

Committed: https://crrev.com/32a3bf47ecd8565d97f1f08597d165c008fe4d30
Cr-Commit-Position: refs/heads/master@{#380113}
==========

[commit-bot: I haz the power, 2016-03-09 10:35:27]

Patchset 3 (id:??) landed as
https://crrev.com/32a3bf47ecd8565d97f1f08597d165c008fe4d30
Cr-Commit-Position: refs/heads/master@{#380113}

[rwlbuis, 2016-03-09 23:10:51]

On 2016/03/09 03:52:41, Timothy Loh wrote:
> lgtm
> 
> On 2016/03/09 03:24:20, rwlbuis wrote:
> > PTAL.
> > 
> > I'll have a look how much work is left remaining for the grid properties to
be
> > ported, or did you already have a look?
> 
> I haven't looked yet.

Ok, many properties are pretty easy, so I'll just start with that, and tackle
the more complex highly self-referential stuff later. Hopefully the more complex
patches can still be kept small.