Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1736763003: Cleanup CSSPropertyParser (Closed)

Created:
4 years, 10 months ago by rwlbuis
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup CSSPropertyParser Remove a large number of methods from the legacy CSSPropertyParser that are not used anymore. Also move isGeneratedImage and createCSSImageValueWithReferrer into CSSPropertyParser.cpp. BUG=499780 Committed: https://crrev.com/32a3bf47ecd8565d97f1f08597d165c008fe4d30 Cr-Commit-Position: refs/heads/master@{#380113}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -2544 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 6 chunks +1 line, -66 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 6 chunks +21 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 3 chunks +623 lines, -2474 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rwlbuis
PTAL. I'll have a look how much work is left remaining for the grid properties ...
4 years, 9 months ago (2016-03-09 03:24:20 UTC) #5
Timothy Loh
lgtm On 2016/03/09 03:24:20, rwlbuis wrote: > PTAL. > > I'll have a look how ...
4 years, 9 months ago (2016-03-09 03:52:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736763003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736763003/40001
4 years, 9 months ago (2016-03-09 09:25:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 10:34:35 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/32a3bf47ecd8565d97f1f08597d165c008fe4d30 Cr-Commit-Position: refs/heads/master@{#380113}
4 years, 9 months ago (2016-03-09 10:35:27 UTC) #12
rwlbuis
4 years, 9 months ago (2016-03-09 23:10:51 UTC) #13
Message was sent while issue was closed.
On 2016/03/09 03:52:41, Timothy Loh wrote:
> lgtm
> 
> On 2016/03/09 03:24:20, rwlbuis wrote:
> > PTAL.
> > 
> > I'll have a look how much work is left remaining for the grid properties to
be
> > ported, or did you already have a look?
> 
> I haven't looked yet.

Ok, many properties are pretty easy, so I'll just start with that, and tackle
the more complex highly self-referential stuff later. Hopefully the more complex
patches can still be kept small.

Powered by Google App Engine
This is Rietveld 408576698