Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1736733003: MD Settings: Custom expand/collapse section animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: function/rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/advanced_page/advanced_page.js
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js
index ddc47feba153860a6904656b52ff322cc9c3f89c..e6655247b0719c7eefa6a1eeff3127f8e194ef9d 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js
@@ -18,6 +18,8 @@
Polymer({
is: 'settings-advanced-page',
+ behaviors: [I18nBehavior, SettingsPageVisibility, RoutableBehavior],
+
properties: {
/**
* Preferences state.
@@ -36,11 +38,26 @@ Polymer({
},
},
+ /**
+ * @type {string} Selector to get the sections.
+ * TODO(michaelpg): replace duplicate docs with @override once b/24294625
+ * is fixed.
+ */
+ sectionSelector: 'settings-section',
+
<if expr="not chromeos">
listeners: {
'dom-change': 'onDomChange_',
},
+</if>
+ /** @override */
+ attached: function() {
+ /** @override */
+ this.scroller = this.parentElement;
+ },
+
+<if expr="not chromeos">
/** @private */
onDomChange_: function() {
var systemPage = /** @type {?SettingsSystemPageElement} */(
@@ -49,6 +66,4 @@ Polymer({
systemPage.delegate = new settings.SystemPageDelegateImpl;
},
</if>
-
- behaviors: [I18nBehavior, SettingsPageVisibility],
});

Powered by Google App Engine
This is Rietveld 408576698