chrome/browser/resources/settings/basic_page/basic_page.js - Issue 1736733003: MD Settings: Custom expand/collapse section animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 1736733003: MD Settings: Custom expand/collapse section animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.html ('k') | chrome/browser/resources/settings/basic_page/compiled_resources.gyp » ('j') | chrome/browser/resources/settings/settings_page/compiled_resources.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/basic_page/basic_page.js

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js

index 217d98f2118e26ecc0103f5eb2f6e8fa875178cf..4746574132fb6ae93139c2e644b7af33ac6fa7d8 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.js

+++ b/chrome/browser/resources/settings/basic_page/basic_page.js

@@ -49,7 +49,20 @@ Polymer({

- behaviors: [I18nBehavior, SettingsPageVisibility],

+ /**

+ * @type {string} Selector to get the sections.

+ * TODO(michaelpg): replace duplicate docs with @override once b/24294625

+ * is fixed.

+ */

+ sectionSelector: 'settings-section',

+ /** @override */

+ attached: function() {

+ /** @override */

+ this.scroller = this.parentElement;

+ },

+ behaviors: [I18nBehavior, SettingsPageVisibility, RoutableBehavior],

onResetDone_: function() {

this.showResetProfileBanner_ = false;