more function refactoring

more function refactoring

Two more small bug caught/fixed in the process:
* Dart lambdas must generate as `=>` functions or we'll get the wrong `this`
* Another case where generators we using destructuring in a mismatched way

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/35707989a54913dd83b8af5d8cdf47299702f458

[Jennifer Messerly, 2016-02-24 23:17:38]

Description was changed from

==========
more function refactoring

2 more small bug fixes caught in the process:
* Dart lambdas must generate as => functions or we'll get the wrong `this`
* Another case where generators we using destructuring in a mismatched way
==========

to

==========
more function refactoring

Two more small bug caught/fixed in the process:
* Dart lambdas must generate as `=>` functions or we'll get the wrong `this`
* Another case where generators we using destructuring in a mismatched way
==========

[Jennifer Messerly, 2016-02-24 23:17:38]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-02-25 00:48:04]

lgtm

https://codereview.chromium.org/1736723002/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1736723002/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:3513: // self-host strong mode.
Probably don't need the TODO anymore.  :-)

[Jennifer Messerly, 2016-02-25 00:53:45]

https://codereview.chromium.org/1736723002/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1736723002/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:3513: // self-host strong mode.
On 2016/02/25 00:48:04, vsm wrote:
> Probably don't need the TODO anymore.  :-)

Yup! Have this fixed in a follow up CL I'm working on. :)

[Jennifer Messerly, 2016-02-25 00:54:10]

Description was changed from

==========
more function refactoring

Two more small bug caught/fixed in the process:
* Dart lambdas must generate as `=>` functions or we'll get the wrong `this`
* Another case where generators we using destructuring in a mismatched way
==========

to

==========
more function refactoring

Two more small bug caught/fixed in the process:
* Dart lambdas must generate as `=>` functions or we'll get the wrong `this`
* Another case where generators we using destructuring in a mismatched way

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/35707989a54913dd83b8af5d8cdf...
==========

[Jennifer Messerly, 2016-02-25 00:54:11]

Committed patchset #2 (id:20001) manually as
35707989a54913dd83b8af5d8cdf47299702f458 (presubmit successful).