Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1736703002: Ensure libusb_close is called from the FILE thread. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure libusb_close is called from the FILE thread. If libusb_close is called from the UsbEventHandler thread then it will deadlock trying to reacquire libusb's open_devs_lock. To avoid this and generally ensure that libusb calls happen on the FILE thread this patch posts a task if the UsbDeviceHandleImpl destructor is not already running on the FILE thread. BUG=589592 Committed: https://crrev.com/449dde0f87ac33b516a1186398d17edbd75e4ee9 Cr-Commit-Position: refs/heads/master@{#377821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M device/usb/usb_device_handle_impl.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 10 months ago (2016-02-24 23:54:17 UTC) #2
Reilly Grant (use Gerrit)
Ping.
4 years, 10 months ago (2016-02-26 02:03:55 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-26 02:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736703002/1
4 years, 10 months ago (2016-02-26 02:08:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/27863) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-26 02:38:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736703002/1
4 years, 10 months ago (2016-02-26 02:43:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/136124)
4 years, 10 months ago (2016-02-26 03:20:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736703002/1
4 years, 10 months ago (2016-02-26 04:58:17 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 05:42:56 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 05:44:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/449dde0f87ac33b516a1186398d17edbd75e4ee9
Cr-Commit-Position: refs/heads/master@{#377821}

Powered by Google App Engine
This is Rietveld 408576698