Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: content/browser/frame_host/frame_mojo_shell.cc

Issue 1736663003: Eliminate Quit() from Shell, and roll Shell & Connector together. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@14cf
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_mojo_shell.h" 5 #include "content/browser/frame_host/frame_mojo_shell.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/browser/mojo/mojo_shell_context.h" 10 #include "content/browser/mojo/mojo_shell_context.h"
(...skipping 22 matching lines...) Expand all
33 33
34 } // namespace 34 } // namespace
35 35
36 FrameMojoShell::FrameMojoShell(RenderFrameHost* frame_host) 36 FrameMojoShell::FrameMojoShell(RenderFrameHost* frame_host)
37 : frame_host_(frame_host) { 37 : frame_host_(frame_host) {
38 } 38 }
39 39
40 FrameMojoShell::~FrameMojoShell() { 40 FrameMojoShell::~FrameMojoShell() {
41 } 41 }
42 42
43 void FrameMojoShell::BindRequest( 43 void FrameMojoShell::BindRequest(mojo::shell::mojom::ConnectorRequest request) {
44 mojo::InterfaceRequest<mojo::shell::mojom::Shell> shell_request) {
45 bindings_.AddBinding(this, std::move(shell_request));
46 }
47
48 void FrameMojoShell::GetConnector(
49 mojo::shell::mojom::ConnectorRequest request) {
50 connectors_.AddBinding(this, std::move(request)); 44 connectors_.AddBinding(this, std::move(request));
51 } 45 }
52 46
53 void FrameMojoShell::QuitApplication() {
54 }
55
56 // TODO(xhwang): Currently no callers are exposing |exposed_services|. So we 47 // TODO(xhwang): Currently no callers are exposing |exposed_services|. So we
57 // drop it and replace it with services we provide in the browser. In the 48 // drop it and replace it with services we provide in the browser. In the
58 // future we may need to support both. 49 // future we may need to support both.
59 void FrameMojoShell::Connect( 50 void FrameMojoShell::Connect(
60 const mojo::String& application_url, 51 const mojo::String& application_url,
61 uint32_t user_id, 52 uint32_t user_id,
62 mojo::shell::mojom::InterfaceProviderRequest services, 53 mojo::shell::mojom::InterfaceProviderRequest services,
63 mojo::shell::mojom::InterfaceProviderPtr /* exposed_services */, 54 mojo::shell::mojom::InterfaceProviderPtr /* exposed_services */,
64 const mojo::shell::mojom::Connector::ConnectCallback& callback) { 55 const mojo::shell::mojom::Connector::ConnectCallback& callback) {
65 // TODO(beng): user_id is dropped on the floor right now. Figure out what to 56 // TODO(beng): user_id is dropped on the floor right now. Figure out what to
(...skipping 21 matching lines...) Expand all
87 // different services for different apps for better isolation. 78 // different services for different apps for better isolation.
88 RegisterFrameMojoShellServices(service_registry_.get(), frame_host_); 79 RegisterFrameMojoShellServices(service_registry_.get(), frame_host_);
89 GetContentClient()->browser()->RegisterFrameMojoShellServices( 80 GetContentClient()->browser()->RegisterFrameMojoShellServices(
90 service_registry_.get(), frame_host_); 81 service_registry_.get(), frame_host_);
91 } 82 }
92 83
93 return service_registry_.get(); 84 return service_registry_.get();
94 } 85 }
95 86
96 } // namespace content 87 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_mojo_shell.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698