Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1736653003:
MIPS: fix test breaks on MIPS64 bit caused by c129aa4d. (Closed)
DescriptionMIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common
operators.'
Port c129aa4d39364bf78d93bec8c16811bfde040a37
Original commit message:
These macro operators represent a conditional eager deoptimization exit
without explicit branching, which greatly reduces overhead of both
scheduling and register allocation, and thereby greatly reduces overall
compilation time, esp. when there are a lot of eager deoptimization
exits.
BUG=
TEST=mjsunit/asm/embenchen/fasta
Committed: https://crrev.com/e9495433aa15a75e9325e5b78d72d084a9a0e306
Cr-Commit-Position: refs/heads/master@{#34301}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== MIPS: fix test breaks on MIPS64 bit caused by c129aa4d. BUG=mjsunit/asm/embenchen/fasta.js ========== to ========== MIPS: fix test breaks on MIPS64 bit caused by c129aa4d. BUG=mjsunit/asm/embenchen/fasta.js ==========
alan.li@imgtec.com changed reviewers: + akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, ivica.bogosavljevic@imgtec.com
Nice catch. The description should be (please try to follow our conventions): MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits.
ilija.pavlovic@imgtec.com changed reviewers: + Ilija.Pavlovic@imgtec.com
This seems to me OK.
Description was changed from ========== MIPS: fix test breaks on MIPS64 bit caused by c129aa4d. BUG=mjsunit/asm/embenchen/fasta.js ========== to ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG=mjsunit/asm/embenchen/fasta.js ==========
alan.li@imgtec.com changed reviewers: + ilija.pavlovic@imgtec.com - Ilija.Pavlovic@imgtec.com
On 2016/02/25 09:44:44, balazs.kilvady wrote: > Nice catch. The description should be (please try to follow our conventions): > MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common > operators.' > > Port c129aa4d39364bf78d93bec8c16811bfde040a37 > > Original commit message: > These macro operators represent a conditional eager deoptimization exit > without explicit branching, which greatly reduces overhead of both > scheduling and register allocation, and thereby greatly reduces overall > compilation time, esp. when there are a lot of eager deoptimization > exits. Done.
Last 2 lines of the description should be: BUG= TEST=mjsunit/asm/embenchen/fasta BUG= is a reference to a reported v8 bug number, like v8:XXXX TEST= can contain the related/effected tests.
Description was changed from ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG=mjsunit/asm/embenchen/fasta.js ========== to ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG=mjsunit/asm/embenchen/fasta ==========
Description was changed from ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG=mjsunit/asm/embenchen/fasta ========== to ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= TEST=mjsunit/asm/embenchen/fasta ==========
On 2016/02/25 13:02:03, balazs.kilvady wrote: > Last 2 lines of the description should be: > BUG= > TEST=mjsunit/asm/embenchen/fasta > > BUG= is a reference to a reported v8 bug number, like v8:XXXX > TEST= can contain the related/effected tests. Thanks for the explanation. Changed accordingly.
lgtm
The CQ bit was checked by alan.li@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736653003/1
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= TEST=mjsunit/asm/embenchen/fasta ========== to ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= TEST=mjsunit/asm/embenchen/fasta ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= TEST=mjsunit/asm/embenchen/fasta ========== to ========== MIPS64: Fix '[turbofan] Introduce DeoptimizeIf And DeoptimizeUnless common operators.' Port c129aa4d39364bf78d93bec8c16811bfde040a37 Original commit message: These macro operators represent a conditional eager deoptimization exit without explicit branching, which greatly reduces overhead of both scheduling and register allocation, and thereby greatly reduces overall compilation time, esp. when there are a lot of eager deoptimization exits. BUG= TEST=mjsunit/asm/embenchen/fasta Committed: https://crrev.com/e9495433aa15a75e9325e5b78d72d084a9a0e306 Cr-Commit-Position: refs/heads/master@{#34301} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e9495433aa15a75e9325e5b78d72d084a9a0e306 Cr-Commit-Position: refs/heads/master@{#34301} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
