content/common/gpu/client/gpu_video_encode_accelerator_host.cc - Issue 1736643005: Decouple Media Service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_video_encode_accelerator_host.cc

Issue 1736643005: Decouple Media Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit + fixed compile issue Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/client/gpu_video_encode_accelerator_host.cc

diff --git a/content/common/gpu/client/gpu_video_encode_accelerator_host.cc b/content/common/gpu/client/gpu_video_encode_accelerator_host.cc

index d240a89d157c556b1df59196fd1278a516f92c03..553fa209d44cf062dbdb39da52005024b54dc9a6 100644

--- a/content/common/gpu/client/gpu_video_encode_accelerator_host.cc

+++ b/content/common/gpu/client/gpu_video_encode_accelerator_host.cc

@@ -9,7 +9,7 @@

#include "base/thread_task_runner_handle.h"

#include "content/common/gpu/client/gpu_channel_host.h"

#include "content/common/gpu/media/gpu_video_accelerator_util.h"

-#include "content/common/gpu/media_messages.h"

+#include "content/common/gpu/media/media_messages.h"

#include "media/base/video_frame.h"

#include "media/video/video_encode_accelerator.h"

#include "ui/gfx/gpu_memory_buffer.h"

@@ -93,10 +93,15 @@ bool GpuVideoEncodeAcceleratorHost::Initialize(

int32_t route_id = channel_->GenerateRouteID();

channel_->AddRoute(route_id, weak_this_factory_.GetWeakPtr());

+ CreateVideoEncoderParams params;

+ params.input_format = input_format;

+ params.input_visible_size = input_visible_size;

+ params.output_profile = output_profile;

+ params.initial_bitrate = initial_bitrate;

+ params.encoder_route_id = route_id;

bool succeeded = false;

- Send(new GpuCommandBufferMsg_CreateVideoEncoder(

- impl_->route_id(), input_format, input_visible_size, output_profile,

- initial_bitrate, route_id, &succeeded));

+ Send(new GpuCommandBufferMsg_CreateVideoEncoder(impl_->route_id(), params,

+ &succeeded));

if (!succeeded) {

DLOG(ERROR) << "Send(GpuCommandBufferMsg_CreateVideoEncoder()) failed";

channel_->RemoveRoute(route_id);