Decouple Media Service

content/common/gpu/media/media_messages.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard here, but see below
 // for a much smaller-than-usual include guard section.
 
 #include "content/common/content_export.h"
+#include "content/common/gpu/media/create_video_encoder_params.h"
 #include "gpu/config/gpu_info.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/param_traits_macros.h"
 #include "media/base/bitstream_buffer.h"
 #include "media/base/decrypt_config.h"
 #include "media/base/video_types.h"
 #include "media/video/jpeg_decode_accelerator.h"
 #include "media/video/video_decode_accelerator.h"
 #include "media/video/video_encode_accelerator.h"
 
@@ skipping 75 matching lines @@
   IPC_STRUCT_TRAITS_MEMBER(max_resolution)
   IPC_STRUCT_TRAITS_MEMBER(max_framerate_numerator)
   IPC_STRUCT_TRAITS_MEMBER(max_framerate_denominator)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(media::SubsampleEntry)
   IPC_STRUCT_TRAITS_MEMBER(clear_bytes)
   IPC_STRUCT_TRAITS_MEMBER(cypher_bytes)
 IPC_STRUCT_TRAITS_END()
 
+IPC_STRUCT_TRAITS_BEGIN(content::CreateVideoEncoderParams)
+  IPC_STRUCT_TRAITS_MEMBER(command_buffer_route_id)
+  IPC_STRUCT_TRAITS_MEMBER(input_format)
+  IPC_STRUCT_TRAITS_MEMBER(input_visible_size)
+  IPC_STRUCT_TRAITS_MEMBER(output_profile)
+  IPC_STRUCT_TRAITS_MEMBER(initial_bitrate)
+  IPC_STRUCT_TRAITS_MEMBER(encoder_route_id)
+IPC_STRUCT_TRAITS_END()
+
+// Create and initialize a hardware jpeg decoder using the specified route_id.
+// Created decoders should be freed with AcceleratedJpegDecoderMsg_Destroy when
+// no longer needed.
+IPC_SYNC_MESSAGE_CONTROL1_1(GpuChannelMsg_CreateJpegDecoder,
+                            int32_t /* route_id */,
+                            bool /* succeeded */)
+
 // Create and initialize a hardware video decoder using the specified route_id.
 // Created decoders should be freed with AcceleratedVideoDecoderMsg_Destroy when
 // no longer needed.
-IPC_SYNC_MESSAGE_ROUTED2_1(GpuCommandBufferMsg_CreateVideoDecoder,
-                           media::VideoDecodeAccelerator::Config, /* config */
-                           int32_t,                               /* route_id */
-                           bool /* succeeded */)
+IPC_SYNC_MESSAGE_CONTROL3_1(GpuCommandBufferMsg_CreateVideoDecoder,

[dcheng, 2016/03/04 02:00:11]

Btw, are these renderer to GPU messages? Or something else? Can we document that
here?

(It's hard for me to tell, since so much of the gpu bits live in content/common)

[Fady Samuel, 2016/03/04 02:30:00]

Good point! I moved them to their appropriate sections in the file.

+                            int32_t /* command_buffer_route_id */,
+                            media::VideoDecodeAccelerator::Config /* config */,
+                            int32_t /* decoder_route_id */,
+                            bool /* succeeded */)
 
 // Create and initialize a hardware video encoder using the specified route_id.
 // Created encoders should be freed with AcceleratedVideoEncoderMsg_Destroy when
 // no longer needed.
-IPC_SYNC_MESSAGE_ROUTED5_1(GpuCommandBufferMsg_CreateVideoEncoder,
-                           media::VideoPixelFormat /* input_format */,
-                           gfx::Size /* input_visible_size */,
-                           media::VideoCodecProfile /* output_profile */,
-                           uint32_t /* initial_bitrate */,
-                           int32_t, /* route_id */
-                           bool /* succeeded */)
+IPC_SYNC_MESSAGE_CONTROL1_1(GpuCommandBufferMsg_CreateVideoEncoder,
+                            content::CreateVideoEncoderParams,
+                            bool /* succeeded */)
 
 //------------------------------------------------------------------------------
 // Accelerated Video Decoder Messages
 // These messages are sent from Renderer process to GPU process.
 
 // Set a CDM on the decoder to handle encrypted buffers.
 IPC_MESSAGE_ROUTED1(AcceleratedVideoDecoderMsg_SetCdm, int32_t /* CDM ID */)
 
 // Send input buffer for decoding.
 IPC_MESSAGE_ROUTED1(AcceleratedVideoDecoderMsg_Decode, media::BitstreamBuffer)
@@ skipping 132 matching lines @@
 IPC_MESSAGE_ROUTED0(AcceleratedJpegDecoderMsg_Destroy)
 
 //------------------------------------------------------------------------------
 // Accelerated JPEG Decoder Host Messages
 // These messages are sent from the GPU process to Browser process.
 //
 // Report decode status.
 IPC_MESSAGE_ROUTED2(AcceleratedJpegDecoderHostMsg_DecodeAck,
                     int32_t, /* bitstream_buffer_id */
                     media::JpegDecodeAccelerator::Error /* error */)