content/common/gpu/media/create_video_encoder_params.h - Issue 1736643005: Decouple Media Service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/gpu/media/create_video_encoder_params.h

Issue 1736643005: Decouple Media Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Daniel's comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_GPU_MEDIA_CREATE_VIDEO_ENCODER_PARAMS_H_

	6 #define CONTENT_COMMON_GPU_MEDIA_CREATE_VIDEO_ENCODER_PARAMS_H_

	7

	8 #include "media/base/video_codecs.h"

	9 #include "media/base/video_types.h"

	10 #include "ui/gfx/geometry/size.h"

	11

	12 namespace content {

	13

	14 struct CreateVideoEncoderParams {

	15 CreateVideoEncoderParams();
	dcheng 2016/03/04 02:00:11 Formatting. Formatting. Fady Samuel 2016/03/04 02:30:00 Done. Show quoted text On 2016/03/04 02:00:11, dcheng wrote: > Formatting. Done.
	16 ~CreateVideoEncoderParams();

	17 int32_t command_buffer_route_id;

	18 media::VideoPixelFormat input_format;

	19 gfx::Size input_visible_size;

	20 media::VideoCodecProfile output_profile;

	21 uint32_t initial_bitrate;

	22 int32_t encoder_route_id;

	23 };

	24

	25 } // namespace content
	dcheng 2016/03/04 02:00:11 Nit: newline after for consistency Nit: newline after for consistency Fady Samuel 2016/03/04 02:30:00 Done. Show quoted text On 2016/03/04 02:00:11, dcheng wrote: > Nit: newline after for consistency Done.
	26 #endif // CONTENT_COMMON_GPU_MEDIA_CREATE_VIDEO_ENCODER_PARAMS_H_

OLD	NEW