Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1736643003: [Interpreter] Use existing type conversion stubs. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Use existing type conversion stubs. We already have stubs for ToName, ToObject and ToNumber, so we can just use them for Ignition instead of the generic runtime calls. R=rmcilroy@chromium.org Committed: https://crrev.com/7ef9b6b88edd464b089b476e777c8724143735d0 Cr-Commit-Position: refs/heads/master@{#34288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M src/interpreter/interpreter.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 11:55:47 UTC) #1
Benedikt Meurer
Hey Ross, Another obvious one. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-25 11:56:18 UTC) #2
rmcilroy
LGTM, thanks.
4 years, 10 months ago (2016-02-25 12:08:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736643003/1
4 years, 10 months ago (2016-02-25 12:09:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 12:15:47 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 12:16:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ef9b6b88edd464b089b476e777c8724143735d0
Cr-Commit-Position: refs/heads/master@{#34288}

Powered by Google App Engine
This is Rietveld 408576698