Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1736633004: Update adb_profile_chrome path in Telemetry (Closed)

Created:
4 years, 10 months ago by Zhen Wang
Modified:
4 years, 10 months ago
Reviewers:
nednguyen, dtu, Sami
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M telemetry/refactor View 1 1 chunk +0 lines, -1 line 2 comments Download
M telemetry/telemetry/internal/platform/profiler/android_systrace_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Zhen Wang
ptal
4 years, 10 months ago (2016-02-24 23:47:03 UTC) #2
Zhen Wang
+nednguyen for telemetry/refactor https://codereview.chromium.org/1736633004/diff/20001/telemetry/refactor File telemetry/refactor (left): https://codereview.chromium.org/1736633004/diff/20001/telemetry/refactor#oldcode32 telemetry/refactor:32: ('tools', 'profile_chrome', 'perf_controller.py'), Ned, is this ...
4 years, 10 months ago (2016-02-24 23:58:00 UTC) #4
nednguyen
lgtm Dave: can we delete telemetry/refactor/.. https://codereview.chromium.org/1736633004/diff/20001/telemetry/refactor File telemetry/refactor (left): https://codereview.chromium.org/1736633004/diff/20001/telemetry/refactor#oldcode32 telemetry/refactor:32: ('tools', 'profile_chrome', 'perf_controller.py'), ...
4 years, 10 months ago (2016-02-25 00:00:22 UTC) #6
Sami
lgtm.
4 years, 10 months ago (2016-02-25 10:46:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736633004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736633004/20001
4 years, 10 months ago (2016-02-25 15:30:11 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 15:40:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698