Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1736633002: remoting: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 10 months ago by vmpstr
Modified:
4 years, 10 months ago
Reviewers:
Nico, dcheng, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remoting: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=garykac@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/83a7f26e6402938c9afe9c68d4a0bd82791614e8 Cr-Commit-Position: refs/heads/master@{#377988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M remoting/base/compound_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/compound_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/setup/gaia_oauth_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/setup/gaia_oauth_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/pairing_registry.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/pairing_registry.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/signaling/server_log_entry.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/signaling/server_log_entry.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/test/connection_setup_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/connection_setup_info.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/test/fake_socket_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/fake_socket_factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/test/host_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/host_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vmpstr
Please take a look.
4 years, 10 months ago (2016-02-24 18:53:54 UTC) #1
dcheng
lgtm
4 years, 10 months ago (2016-02-24 21:14:18 UTC) #2
vmpstr
ping for owners
4 years, 10 months ago (2016-02-26 19:44:42 UTC) #3
garykac
lgtm
4 years, 10 months ago (2016-02-26 20:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736633002/1
4 years, 10 months ago (2016-02-26 21:03:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 21:47:02 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:49:25 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/83a7f26e6402938c9afe9c68d4a0bd82791614e8
Cr-Commit-Position: refs/heads/master@{#377988}

Powered by Google App Engine
This is Rietveld 408576698