Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/a64/lithium-codegen-a64.cc

Issue 173663002: A64: Tidy up register use in TaggedToI (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | src/a64/macro-assembler-a64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/lithium-codegen-a64.cc
diff --git a/src/a64/lithium-codegen-a64.cc b/src/a64/lithium-codegen-a64.cc
index 2052a27c9743e5a5b238d688bae06b619a0c9d28..ace96598a8c1931ee41ef10ba2bc2b72bd6dec5b 100644
--- a/src/a64/lithium-codegen-a64.cc
+++ b/src/a64/lithium-codegen-a64.cc
@@ -5368,17 +5368,11 @@ void LCodeGen::DoTaggedToI(LTaggedToI* instr) {
Register output = ToRegister(instr->result());
if (instr->hydrogen()->value()->representation().IsSmi()) {
- __ SmiUntag(input);
+ __ SmiUntag(output, input);
} else {
DeferredTaggedToI* deferred = new(zone()) DeferredTaggedToI(this, instr);
- // TODO(jbramley): We can't use JumpIfNotSmi here because the tbz it uses
- // doesn't always have enough range. Consider making a variant of it, or a
- // TestIsSmi helper.
- STATIC_ASSERT(kSmiTag == 0);
- __ Tst(input, kSmiTagMask);
- __ B(ne, deferred->entry());
-
+ __ JumpIfNotSmi(input, deferred->entry());
__ SmiUntag(output, input);
__ Bind(deferred->exit());
}
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | src/a64/macro-assembler-a64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698