Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 173663002: A64: Tidy up register use in TaggedToI (Closed)

Created:
6 years, 10 months ago by m.m.capewell
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Tidy up register use in TaggedToI Fix bug where input register was potentially corrupted, tidy up register use in TruncateDoubleToI and rename TryInlineTruncateDoubleToI. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M src/a64/code-stubs-a64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M test/cctest/test-code-stubs-a64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
m.m.capewell
6 years, 10 months ago (2014-02-20 11:21:00 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-20 11:39:59 UTC) #2
m.m.capewell
Committed patchset #1 manually as r19527 (presubmit successful).
6 years, 10 months ago (2014-02-21 11:36:12 UTC) #3
ulan
6 years, 10 months ago (2014-02-24 07:52:41 UTC) #4
Message was sent while issue was closed.
On 2014/02/21 11:36:12, m.m.capewell wrote:
> Committed patchset #1 manually as r19527 (presubmit successful).

This regressed webkit/fast/js/kde/md5-1:
https://code.google.com/p/v8/issues/detail?id=3177

Powered by Google App Engine
This is Rietveld 408576698