gm/tests/run.sh - Issue 17366003: GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/tests/run.sh

Issue 17366003: GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: add_pdf Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gm/tests/outputs/add-config-pdf/output-expected/json-summary.txt ('K') | « gm/tests/outputs/add-config-pdf/output-expected/writePath/pdf/selftest1.pdf ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gm/tests/run.sh

===================================================================

--- gm/tests/run.sh (revision 9647)

+++ gm/tests/run.sh (working copy)

@@ -108,6 +108,9 @@

for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name *.png); do

echo "[contents of $IMAGEFILE]" >$IMAGEFILE

done

+ for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name *.pdf); do

epoger 2013/06/18 04:32:27 I had to add this special treatment for the PDF fi

+ echo "[contents of $IMAGEFILE]" >$IMAGEFILE

+ done

if [ -d $ACTUAL_OUTPUT_DIR/mismatchPath ]; then

for MISMATCHDIR in $(find $ACTUAL_OUTPUT_DIR/mismatchPath -mindepth 1 -type d); do

echo "Created additional file to make sure directory isn't empty, because self-test cannot handle empty directories." >$MISMATCHDIR/bogusfile

@@ -199,6 +202,9 @@

# Compare generated image against an empty "expected image" dir, but NOT in verbose mode.

gm_test "--hierarchy --match selftest1 $CONFIGS -r $GM_INPUTS/images/empty-dir" "$GM_OUTPUTS/nonverbose"

+# Add pdf to the list of configs.

+gm_test "--verbose --hierarchy --match selftest1 $CONFIGS pdf -r $GM_INPUTS/json/identical-bytes.json" "$GM_OUTPUTS/add-config-pdf"

# If run without "-r", the JSON's "actual-results" section should contain

# actual checksums marked as "failure-ignored", but the "expected-results"

# section should be empty.