gm/tests/outputs/add-config-pdf/output-expected/json-summary.txt - Issue 17366003: GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gm/tests/outputs/add-config-pdf/output-expected/json-summary.txt

Issue 17366003: GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: add_pdf Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« gm/tests/outputs/add-config-pdf/output-expected/command_line ('K') | « gm/tests/outputs/add-config-pdf/output-expected/command_line ('k') | gm/tests/outputs/add-config-pdf/output-expected/mismatchPath/565/bogusfile » ('j') | gm/tests/run.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "actual-results" : {

	3 "failed" : null,

	4 "failure-ignored" : null,

	5 "no-comparison" : {

	6 "pdf/selftest1.png" : [ "INVALID" ]
	epoger 2013/06/18 04:32:27 ... and here we see the "INVALID" line! I think w ... and here we see the "INVALID" line! I think what's happening here is that the JSON-writing code in gm is attempting to get a BitmapHash of the PDF output. (It shouldn't be doing that, because it's not a bitmap.)
	7 },

	8 "succeeded" : {

	9 "565/selftest1.png" : [ "bitmap-64bitMD5", 12927999507540085554 ],

	10 "8888/selftest1.png" : [ "bitmap-64bitMD5", 1209453360120438698 ]

	11 }

	12 },

	13 "expected-results" : {

	14 "565/selftest1.png" : {

	15 "allowed-digests" : [

	16 [ "bitmap-64bitMD5", 12927999507540085554 ]

	17 ],

	18 "ignore-failure" : false

	19 },

	20 "8888/selftest1.png" : {

	21 "allowed-digests" : [

	22 [ "bitmap-64bitMD5", 1209453360120438698 ]

	23 ],

	24 "ignore-failure" : false

	25 }

	26 }

	27 }

OLD	NEW