Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 17365006: Add GM to test conic path rendering (Closed)

Created:
7 years, 6 months ago by egdaniel
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add GM to test conic path rendering R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9702

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -0 lines) Patch
A gm/conicpaths.cpp View 1 1 chunk +164 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
egdaniel
My guess is this test will show a few errors in both the cpu and ...
7 years, 6 months ago (2013-06-20 15:15:54 UTC) #1
reed1
just some modernization nits https://codereview.chromium.org/17365006/diff/1/gm/conicpaths.cpp File gm/conicpaths.cpp (right): https://codereview.chromium.org/17365006/diff/1/gm/conicpaths.cpp#newcode21 gm/conicpaths.cpp:21: virtual SkISize onISize() { return ...
7 years, 6 months ago (2013-06-20 15:22:32 UTC) #2
egdaniel
fixed nits
7 years, 6 months ago (2013-06-20 15:33:57 UTC) #3
reed1
lgtm
7 years, 6 months ago (2013-06-20 15:58:47 UTC) #4
egdaniel
7 years, 6 months ago (2013-06-20 16:54:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r9702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698