Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 17365004: Update SVG interfaces to stop inheriting from SVGURIReference (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, pdr, f(malita), Stephen Chennney, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Update SVG interfaces to stop inheriting from SVGURIReference According to the latest specification, SVGAElement should implement SVGURIReference, not inherit it. This patch also updates other interfaces to use implements statements instead of inheritance. While this is no longer part of the specification, this was done to maintain backward compatibility. This is one step towards getting rid of multiple inheritence in SVG. There is no webexposed behavior change. Specification: http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGAElement BUG=252181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGradientElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTRefElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGURIReference.idl View 1 chunk +18 lines, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-20 12:34:51 UTC) #1
haraken
LGTM, but stephen might want to take a look.
7 years, 6 months ago (2013-06-20 12:38:46 UTC) #2
arv (Not doing code reviews)
LGTM
7 years, 6 months ago (2013-06-20 13:49:42 UTC) #3
Stephen Chennney
lgtm
7 years, 6 months ago (2013-06-20 17:08:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17365004/1
7 years, 6 months ago (2013-06-20 17:09:13 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 18:44:01 UTC) #6
Message was sent while issue was closed.
Change committed as 152806

Powered by Google App Engine
This is Rietveld 408576698