Quick-fix for `annotate_overrides` lint (#25416).

Quick-fix for `annotate_overrides` lint (#25416).

An interim approach to shoe lint-awareness into the dart FixProcessor.  Once we have a a shareable processor base class we can migrate these bits into a dedicated LintFixProcessor contributed by the LintServerPlugin.

See: https://github.com/dart-lang/sdk/issues/25416

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/549a7a4d00c73a918439cdcb3601001e1955a581

[pquitslund, 2016-02-26 22:13:37]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-02-26 22:17:21]

LGTM

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix.dart (right):

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix.dart:170: const
FixKind('ADD_OVERRIDE', 50, "Add '@override' annotation");
Maybe use the same name as the constant name (LINT_ADD_OVERRIDE), i.e.
  const FixKind('LINT_ADD_OVERRIDE', 50, "Add '@override' annotation");

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:2212:
ClassMember body = node.getAncestor((n) => n is ClassMember);
body => member?

[pquitslund, 2016-02-26 22:21:13]

Thanks!

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix.dart (right):

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix.dart:170: const
FixKind('ADD_OVERRIDE', 50, "Add '@override' annotation");
On 2016/02/26 22:17:20, scheglov wrote:
> Maybe use the same name as the constant name (LINT_ADD_OVERRIDE), i.e.
>   const FixKind('LINT_ADD_OVERRIDE', 50, "Add '@override' annotation");

Done.

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/1736383002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:2212:
ClassMember body = node.getAncestor((n) => n is ClassMember);
On 2016/02/26 22:17:20, scheglov wrote:
> body => member?

Done.

[pquitslund, 2016-02-26 22:23:10]

Description was changed from

==========
Quick-fix for `annotate_overrides` lint (#25416).

An interim approach to shoe lint-awareness into the dart FixProcessor.  Once we
have a a shareable processor base class we can migrate these bits into a
dedicated LintFixProcessor contributed by the LintServerPlugin.

See: https://github.com/dart-lang/sdk/issues/25416

BUG=
==========

to

==========
Quick-fix for `annotate_overrides` lint (#25416).

An interim approach to shoe lint-awareness into the dart FixProcessor.  Once we
have a a shareable processor base class we can migrate these bits into a
dedicated LintFixProcessor contributed by the LintServerPlugin.

See: https://github.com/dart-lang/sdk/issues/25416

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/549a7a4d00c73a918439cdcb3601001e1955a581
==========

[pquitslund, 2016-02-26 22:23:11]

Committed patchset #2 (id:20001) manually as
549a7a4d00c73a918439cdcb3601001e1955a581 (presubmit successful).

[Brian Wilkerson, 2016-02-26 22:43:35]

LGTM

https://codereview.chromium.org/1736383002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/correction/fix.dart (right):

https://codereview.chromium.org/1736383002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/correction/fix.dart:49: bool
hasFix(ErrorCode errorCode) =>
This method should be updated. It's how Atom knows to indicate that a fix is
available.

[pquitslund, 2016-02-26 22:49:37]

On 2016/02/26 22:43:35, Brian Wilkerson wrote:
> LGTM
> 
>
https://codereview.chromium.org/1736383002/diff/20001/pkg/analysis_server/lib...
> File pkg/analysis_server/lib/src/services/correction/fix.dart (right):
> 
>
https://codereview.chromium.org/1736383002/diff/20001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/services/correction/fix.dart:49: bool
> hasFix(ErrorCode errorCode) =>
> This method should be updated. It's how Atom knows to indicate that a fix is
> available.

Yes!  Thank you.  I thought of that and then totally spaced.  Update here:

https://codereview.chromium.org/1741133002/