Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1736373002: FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons (Closed)

Created:
4 years, 9 months ago by benjhayden
Modified:
4 years, 9 months ago
Reviewers:
nduca, Sami
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons These objects represent the FrameTreeNode and RenderFrame objects. They don't do anything yet. See also https://codereview.chromium.org/1390053002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a3910df743d6e4268508e07f34ed2283b1f05525

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M tracing/trace_viewer.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tracing/tracing/extras/chrome/frame_tree_node.html View 1 1 chunk +58 lines, -0 lines 0 comments Download
A tracing/tracing/extras/chrome/render_frame.html View 1 1 chunk +58 lines, -0 lines 0 comments Download
M tracing/tracing/extras/chrome_config.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
benjhayden
PTAL
4 years, 9 months ago (2016-03-11 01:45:51 UTC) #4
nduca
https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chrome/frame_tree_node.html File tracing/tracing/extras/chrome/frame_tree_node.html (right): https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chrome/frame_tree_node.html#newcode34 tracing/tracing/extras/chrome/frame_tree_node.html:34: var frameNumber; this whole body feels wrong? https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chrome/render_frame.html File ...
4 years, 9 months ago (2016-03-14 22:24:52 UTC) #6
benjhayden
PTAL https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chrome/frame_tree_node.html File tracing/tracing/extras/chrome/frame_tree_node.html (right): https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chrome/frame_tree_node.html#newcode34 tracing/tracing/extras/chrome/frame_tree_node.html:34: var frameNumber; Yeah, it was copy-pasta. I wasn't ...
4 years, 9 months ago (2016-03-17 22:55:28 UTC) #7
nduca
lgtm
4 years, 9 months ago (2016-03-17 23:53:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736373002/20001
4 years, 9 months ago (2016-03-18 17:26:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/2326)
4 years, 9 months ago (2016-03-18 20:08:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736373002/40001
4 years, 9 months ago (2016-03-21 18:06:49 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:43:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698