FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects.

They don't do anything yet.

See also https://codereview.chromium.org/1390053002

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a3910df743d6e4268508e07f34ed2283b1f05525

[benjhayden, 2016-02-26 21:58:28]

Description was changed from

==========
FrameTreeNode, RenderFrame
==========

to

==========
FrameTreeNode, RenderFrame

See also https://codereview.chromium.org/1390053002
==========

[benjhayden, 2016-02-26 22:00:38]

Description was changed from

==========
FrameTreeNode, RenderFrame

See also https://codereview.chromium.org/1390053002
==========

to

==========
FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects,
and allow the model importer to patch up references between them.

See also https://codereview.chromium.org/1390053002
==========

[benjhayden, 2016-03-11 01:45:50]

benjhayden@chromium.org changed reviewers:
+ nduca@chromium.org, skyostil@chromium.org

[benjhayden, 2016-03-11 01:45:51]

PTAL

[benjhayden, 2016-03-11 01:55:34]

Description was changed from

==========
FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects,
and allow the model importer to patch up references between them.

See also https://codereview.chromium.org/1390053002
==========

to

==========
FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects.

They don't do anything yet.

See also https://codereview.chromium.org/1390053002
==========

[nduca, 2016-03-14 22:24:52]

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/frame_tree_node.html (right):

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/frame_tree_node.html:34: var frameNumber;
this whole body feels wrong?

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/render_frame.html (right):

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/render_frame.html:34: var frameNumber;
probably no?

[benjhayden, 2016-03-17 22:55:28]

PTAL

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/frame_tree_node.html (right):

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/frame_tree_node.html:34: var frameNumber;
Yeah, it was copy-pasta.
I wasn't sure what it should contain, so now it just returns a constant
'FrameTreeNode'.

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
File tracing/tracing/extras/chrome/render_frame.html (right):

https://codereview.chromium.org/1736373002/diff/1/tracing/tracing/extras/chro...
tracing/tracing/extras/chrome/render_frame.html:34: var frameNumber;
On 2016/03/14 at 22:24:52, nduca wrote:
> probably no?

Right, it was just copy-pasta.
I wasn't sure what it should contain, so now it just returns a constant
'RenderFrame'.

[nduca, 2016-03-17 23:53:22]

lgtm

[benjhayden, 2016-03-18 17:26:10]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-03-18 17:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736373002/20001

[commit-bot: I haz the power, 2016-03-18 20:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:08:30]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2016-03-21 18:06:38]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-03-21 18:06:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1736373002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-21 18:06:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1736373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1736373002/40001

[commit-bot: I haz the power, 2016-03-21 18:43:10]

Description was changed from

==========
FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects.

They don't do anything yet.

See also https://codereview.chromium.org/1390053002
==========

to

==========
FrameTreeNode, RenderFrame ObjectSnapshot/Instance skeletons

These objects represent the FrameTreeNode and RenderFrame objects.

They don't do anything yet.

See also https://codereview.chromium.org/1390053002

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-03-21 18:43:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...