Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1736343002: [Android] Use incognito spinner resource for incognito page loads (Closed)

Created:
4 years, 10 months ago by mcdavid
Modified:
4 years, 9 months ago
Reviewers:
Changwan Ryu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use incognito spinner resource for incognito page loads The incognito spinner resource was being initalized with the normal resource instead. Fixed it to use the correct resource. BUG=590308 TEST=Open incognito tab, load google.com Committed: https://crrev.com/3a698e6f991ac64bf075c12afdf0da74f5b8bf3a Cr-Commit-Position: refs/heads/master@{#378265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/compositor/decoration_title.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mcdavid
4 years, 10 months ago (2016-02-26 20:23:42 UTC) #3
Changwan Ryu
lgtm
4 years, 9 months ago (2016-02-27 10:14:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736343002/1
4 years, 9 months ago (2016-02-29 19:56:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 20:49:37 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:50:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a698e6f991ac64bf075c12afdf0da74f5b8bf3a
Cr-Commit-Position: refs/heads/master@{#378265}

Powered by Google App Engine
This is Rietveld 408576698