Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1736293004: Fix shelf crash on windows (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix shelf crash on windows In debug builds it doesn't appear that windows makes string constants equal if the text is the same. This means the getter always returned null. BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/1468c64622a576044e7cd5d5fe96b175a3c75370 Cr-Commit-Position: refs/heads/master@{#378058}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : MUS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M ui/aura/mus/mus_util.cc View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 10 months ago (2016-02-27 00:00:52 UTC) #1
msw
lgtm
4 years, 10 months ago (2016-02-27 00:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736293004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736293004/40001
4 years, 10 months ago (2016-02-27 00:19:42 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-27 01:31:39 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 01:32:34 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1468c64622a576044e7cd5d5fe96b175a3c75370
Cr-Commit-Position: refs/heads/master@{#378058}

Powered by Google App Engine
This is Rietveld 408576698