Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1736273002: Add some missing std::move()s following a previous refactoring (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, extensions-reviews_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing std::move()s following a previous refactoring This patch adds some std::move() calls as a follow-up to https://codereview.chromium.org/1730533002/. No functional changes. BUG=546953 TBR=rsleevi@chromium.org Committed: https://crrev.com/15ecd66e89a3a6be11e416788f3214d97ea0662a Cr-Commit-Position: refs/heads/master@{#377898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Sami
Thanks for pointing these out Ryan. I don't quite have std::move() embedded in my muscle ...
4 years, 10 months ago (2016-02-26 15:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736273002/1
4 years, 10 months ago (2016-02-26 15:59:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 16:18:40 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 16:19:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15ecd66e89a3a6be11e416788f3214d97ea0662a
Cr-Commit-Position: refs/heads/master@{#377898}

Powered by Google App Engine
This is Rietveld 408576698