Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1736253003: Revert of PPC: [compiler] Drop the CompareNilIC. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC: [compiler] Drop the CompareNilIC. (patchset #1 id:1 of https://codereview.chromium.org/1733663003/ ) Reason for revert: Original commit reverted. Original issue's description: > PPC: [compiler] Drop the CompareNilIC. > > Port 666aec0348c8793e61c8633dee7ad29a514239ba > > Original commit message: > Since both null and undefined are also marked as undetectable now, we > can just test that bit instead of having the CompareNilIC try to collect > feedback to speed up the general case (without the undetectable bit > being used). > > Drive-by-fix: Update the type system to match the new handling of > undetectable in the runtime. > > R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > > Committed: https://crrev.com/546ea6b8393a894f07597ade5ec1c7db02c1e425 > Cr-Commit-Position: refs/heads/master@{#34266} TBR=bmeurer@chromium.org,joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/76b6615947b3c106844f51ce6bbdb2c77ffc2748 Cr-Commit-Position: refs/heads/master@{#34340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
Created Revert of PPC: [compiler] Drop the CompareNilIC.
4 years, 9 months ago (2016-02-26 21:24:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736253003/1
4 years, 9 months ago (2016-02-26 21:24:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736253003/1
4 years, 9 months ago (2016-02-26 21:32:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 21:46:06 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 21:46:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b6615947b3c106844f51ce6bbdb2c77ffc2748
Cr-Commit-Position: refs/heads/master@{#34340}

Powered by Google App Engine
This is Rietveld 408576698