Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1736233002: [interpreter] ToObject never yields null. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] ToObject never yields null. We don't need to compare the result of ToObject against null, since ToObject will always yield a proper receiver (or throw a TypeError). R=rmcilroy@chromium.org Committed: https://crrev.com/06fe8afe7f836c0c2213d6efb2e29eb2f172275e Cr-Commit-Position: refs/heads/master@{#34318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M src/interpreter/bytecode-generator.cc View 3 chunks +1 line, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 4 chunks +12 lines, -16 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-26 05:30:49 UTC) #1
Benedikt Meurer
Hey Ross, We don't need to check the result of ToObject in ForIn. Please take ...
4 years, 10 months ago (2016-02-26 05:31:40 UTC) #2
rmcilroy
LGTM, thanks!
4 years, 10 months ago (2016-02-26 08:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736233002/1
4 years, 10 months ago (2016-02-26 08:44:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 08:45:57 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 08:47:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06fe8afe7f836c0c2213d6efb2e29eb2f172275e
Cr-Commit-Position: refs/heads/master@{#34318}

Powered by Google App Engine
This is Rietveld 408576698