Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 173618: Remove Mac layout test expectations that are now passing (Closed)

Created:
11 years, 3 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)
Visibility:
Public.

Description

Remove Mac layout test expectations that are now passing and no longer flaky. BUG=18569, 13692, 10374, 10375, 10384, 10418, 9798, 11469, 11810, 20442 TEST=Covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24840

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 2 3 4 8 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
11 years, 3 months ago (2009-08-29 00:02:58 UTC) #1
ojan
11 years, 3 months ago (2009-08-29 00:06:59 UTC) #2 
w00t! LGTM

On Fri, Aug 28, 2009 at 5:02 PM, <paul@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Remove Mac layout test expectations that are now passing and no
> longer flaky.
>
> BUG=18569,13692,10374,10375,10384,10418,9798,11469,11810,20442
> TEST=Covered by layout tests
>
>
> Please review this at http://codereview.chromium.org/173618
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24836)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1187,8 +1187,6 @@
>  BUG13692 WIN : LayoutTests/dom/html/level2/html/HTMLParamElement03.html =
> CRASH PASS
>  BUG13692 WIN : LayoutTests/svg/custom/polyline-hittest.svg = CRASH PASS
>  BUG13692 WIN : LayoutTests/tables/mozilla/marvin/tables_bgcolor_green.html
> = CRASH PASS
> -BUG13692 MAC : LayoutTests/fast/dom/Document/open-with-pending-load.html =
> CRASH PASS
> -BUG13692 MAC : LayoutTests/fast/invalid/019.html = CRASH PASS
>
>  // <body><canvas height=100></canvas></body> is 1 px taller than upstream.
>  BUG13809 WIN LINUX :
> LayoutTests/fast/canvas/canvas-empty-image-pattern.html = FAIL
> @@ -1501,16 +1499,7 @@
>  // window.open crashes (some of these are flaky, in that they don't always
>  // crash, and are noted as such)
>  BUG10374 MAC : LayoutTests/plugins/open-and-close-window-with-plugin.html
> = CRASH TIMEOUT FAIL
> -BUG10374 MAC :
> LayoutTests/fast/dom/Window/setting-properties-on-closed-window.html = CRASH
> TIMEOUT PASS
> -BUG10374 MAC : LayoutTests/fast/events/open-window-from-another-frame.html
> = CRASH TIMEOUT PASS
> -BUG10374 MAC : LayoutTests/fast/history/history_reload.html = CRASH
> TIMEOUT PASS
> -SLOW BUG10374 MAC : LayoutTests/svg/carto.net/scrollbar.svg = CRASH PASS
>
> -//  no html tags, bad html (unmatched tags)
> -BUG10375 MAC : LayoutTests/fast/canvas/unclosed-canvas-1.html = CRASH PASS
> -// Script -- onload hooks
> -BUG10375 MAC : LayoutTests/fast/dom/Document/early-document-access.html =
> CRASH TIMEOUT PASS
> -
>  // Not really sure why these are failing at the moment
>  BUG10376 MAC : LayoutTests/fast/dom/isindex-002.html = FAIL
>  BUG10376 MAC : LayoutTests/fast/events/init-events.html = FAIL
> @@ -1586,7 +1575,6 @@
>  // the file, but they were left there as the comments in those areas are
> valid.)
>  BUG10384 MAC :
> LayoutTests/animations/animation-end-event-destroy-renderer.html = TIMEOUT
> PASS
>  BUG10384 MAC :
> LayoutTests/fast/images/animated-background-image-crash.html = TIMEOUT PASS
> -BUG10384 MAC :
>
LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html
> = CRASH TIMEOUT FAIL PASS
>  BUG10384 MAC : LayoutTests/fast/css/background-shorthand-invalid-url.html
> = CRASH PASS
>  BUG10384 MAC : LayoutTests/fast/dom/Window/window-early-properties.html =
> CRASH TIMEOUT PASS
>  BUG10674 MAC : chrome/http/tests/misc/set-window-opener-to-null.html =
> PASS TIMEOUT FAIL
> @@ -1712,7 +1700,6 @@
>  // New test. We should fix it, but it doesn't need to block the current
> release
>  BUG10418 :
> LayoutTests/transitions/zero-duration-with-non-zero-delay-end.html = FAIL
> PASS
>  BUG10418 SLOW MAC : LayoutTests/fast/events/click-count.html = FAIL PASS
> -BUG10418 MAC : LayoutTests/fast/dom/Window/timeout-callback-scope.html =
> CRASH PASS
>  BUG10418 : LayoutTests/animations/change-keyframes.html = FAIL PASS
>
>  // TODO(dsh): These started to fail after r9202.
> @@ -2040,7 +2027,6 @@
>  BUG9798 MAC : LayoutTests/fast/images/load-img-with-empty-src.html = FAIL
> PASS
>  BUG9798 MAC :
> LayoutTests/http/tests/security/cross-frame-access-name-getter.html = FAIL
> PASS
>  BUG9798 MAC :
> LayoutTests/http/tests/security/cross-frame-access-selection.html = FAIL
> PASS
> -BUG9798 MAC :
>
LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html
> = FAIL CRASH PASS
>  BUG9798 MAC :
>
LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html
> = FAIL PASS
>  BUG9798 MAC :
>
LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html
> = FAIL PASS
>  BUG9798 MAC :
>
LayoutTests/http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html
> = FAIL PASS
> @@ -2225,8 +2211,6 @@
>  // Regressions from WebKit Merge 43059:43114
>  BUG11322 : LayoutTests/editing/text-iterator/basic-iteration.html = FAIL
>
> -BUG11469 MAC : LayoutTests/fast/repaint/outline-shrinking.html = CRASH
> PASS
> -
>  // Regresssions from WebKit Merge 43114:43242 that just need to be
> re-baselined.
>  BUG11483 LINUX : LayoutTests/fast/forms/input-text-double-click.html =
> FAIL
>  BUG11483 LINUX : LayoutTests/svg/text/foreignObject-repaint.xml = FAIL
> @@ -2272,10 +2256,7 @@
>
>  // Flaky Mac tests
>  BUG11810 MAC : LayoutTests/http/tests/navigation/post-goback-same-url.html
> = TIMEOUT PASS
> -BUG11810 MAC : LayoutTests/svg/custom/polyline-points-crash.html = CRASH
> PASS
>  BUG11810 MAC : LayoutTests/editing/selection/extend-selection.html =
> TIMEOUT PASS
> -BUG11810 MAC DEBUG : LayoutTests/fast/repaint/subtree-root-clip.html =
> CRASH PASS
> -BUG11810 MAC DEBUG :
> LayoutTests/http/tests/security/originHeader/origin-header-for-empty.html =
> TIMEOUT FAIL CRASH PASS
>
>  // Flaky Linux tests
>  BUG11832 LINUX : LayoutTests/svg/custom/circular-marker-reference-4.svg =
> FAIL PASS
> @@ -2579,7 +2560,6 @@
>
>  // Flaky crashes
>  BUG18206 LINUX MAC :
>
LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
> = CRASH PASS
> -BUG18569 MAC DEBUG : LayoutTests/fast/repaint/overflow-scroll-delete.html
> = PASS CRASH
>  BUG18656 LINUX : LayoutTests/fast/overflow/overflow-stacking.html = PASS
> CRASH
>  BUG18656 MAC : LayoutTests/fast/dom/Window/window-lookup-precedence.html =
> FAIL CRASH
>  BUG18724 LINUX DEBUG :
> LayoutTests/transitions/transition-drt-api-delay.html = PASS CRASH
>
>
>

Powered by Google App Engine
This is Rietveld 408576698