Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1736163002:
Make the lists in the password section flex up to 245px. (Closed)
|
Created:
4 years, 10 months ago by hcarmona Modified:
4 years, 10 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the lists in the password section flex up to 245px.
This addresses a TODO in the code to make the section flex.
BUG=546836
Committed: https://crrev.com/9f9d842c7a501f7a993f5bee61706c8fef1ac457
Cr-Commit-Position: refs/heads/master@{#377792}
Patch Set 1 #
Total comments: 1
Patch Set 2 : pt -> px #Messages
Total messages: 21 (9 generated)
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org
PTAL
https://codereview.chromium.org/1736163002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.css (right): https://codereview.chromium.org/1736163002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.css:13: max-height: 245pt; * why 245pt? * why use "pt" instead of px? just wondering what the precedent will be, because we have other iron-lists that need to be sized.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
i think most of the time when bettes@ puts "pt" in the mocks it is equivalent to "px" in the code
Description was changed from ========== Make the lists in the password section flex up to 245pt. This addresses a TODO in the code to make the section flex. BUG=546836 ========== to ========== Make the lists in the password section flex up to 245pt. This addresses a TODO in the code to make the section flex. BUG=546836 ==========
dbeam@chromium.org changed reviewers: - dbeam@chromium.org
Got 245pt from go/jrcnq I will change to "px", I just used "pt" b/c that's what was in the mock.
Description was changed from ========== Make the lists in the password section flex up to 245pt. This addresses a TODO in the code to make the section flex. BUG=546836 ========== to ========== Make the lists in the password section flex up to 245px. This addresses a TODO in the code to make the section flex. BUG=546836 ==========
On 2016/02/26 00:43:03, Dan Beam wrote: > i think most of the time when bettes@ puts "pt" in the mocks it is equivalent to > "px" in the code pt is not (necessarily) equal to px, you sure that's what he meant?
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
On 2016/02/26 00:53:42, michaelpg wrote: > On 2016/02/26 00:43:03, Dan Beam wrote: > > i think most of the time when bettes@ puts "pt" in the mocks it is equivalent > to > > "px" in the code > > pt is not (necessarily) equal to px, you sure that's what he meant? yes, I understand the difference. here's a good article for those that want a refresher: http://kyleschaeffer.com/development/css-font-size-em-vs-px-vs-pt-vs/ he said he's using px in the newest mocks
lgtm
lgtm
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736163002/20001
Message was sent while issue was closed.
Description was changed from ========== Make the lists in the password section flex up to 245px. This addresses a TODO in the code to make the section flex. BUG=546836 ========== to ========== Make the lists in the password section flex up to 245px. This addresses a TODO in the code to make the section flex. BUG=546836 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make the lists in the password section flex up to 245px. This addresses a TODO in the code to make the section flex. BUG=546836 ========== to ========== Make the lists in the password section flex up to 245px. This addresses a TODO in the code to make the section flex. BUG=546836 Committed: https://crrev.com/9f9d842c7a501f7a993f5bee61706c8fef1ac457 Cr-Commit-Position: refs/heads/master@{#377792} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9f9d842c7a501f7a993f5bee61706c8fef1ac457 Cr-Commit-Position: refs/heads/master@{#377792}
Message was sent while issue was closed.
On 2016/02/26 01:01:54, Dan Beam wrote: > On 2016/02/26 00:53:42, michaelpg wrote: > > On 2016/02/26 00:43:03, Dan Beam wrote: > > > i think most of the time when bettes@ puts "pt" in the mocks it is > equivalent > > to > > > "px" in the code > > > > pt is not (necessarily) equal to px, you sure that's what he meant? > > yes, I understand the difference. was asking for my sake. not yours here's a good article for those that want a > refresher: > http://kyleschaeffer.com/development/css-font-size-em-vs-px-vs-pt-vs/ > > he said he's using px in the newest mocks thanks |
