Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 173614: De-orange the layout tests: remove passing tests from the list and add PASS... (Closed)

Created:
11 years, 3 months ago by Pam (message me for reviews)
Modified:
9 years, 5 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)
Visibility:
Public.

Description

De-orange the layout tests: remove passing tests from the list and add PASS notation where needed. Haven't failed in 100+ builds: LINUX : LayoutTests/fast/history/back-forward-is-asynchronous.html LINUX : LayoutTests/fast/multicol/columns-shorthand-parsing.html MAC : LayoutTests/fast/css/only-of-type-pseudo-class.html MAC : LayoutTests/fast/events/pointer-events-2.html MAC : LayoutTests/fast/forms/listbox-onchange.html MAC : LayoutTests/fast/forms/listbox-selection.html MAC : LayoutTests/fast/forms/button-state-restore.html MAC : LayoutTests/fast/forms/input-type-change2.html Have been passing occasionally for at least 100 builds: LINUX : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html LINUX : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-prop.html Apparently fixed by r24625: MAC : LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html MAC : LayoutTests/http/tests/security/cross-frame-access-protocol.html MAC : LayoutTests/http/tests/security/originHeader/origin-header-for-https.html Apparently fixed sometime before build 2930 (r24560): r24546-24548 MAC : LayoutTests/fast/history/back-forward-is-asynchronous.html BUG=5248, 18896, 19842, 20340, 20314 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 7 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Pam (message me for reviews)
11 years, 3 months ago (2009-08-28 20:42:45 UTC) #1
ojan
11 years, 3 months ago (2009-08-28 21:02:41 UTC) #2
LGTM! Thanks for doing this.

On Fri, Aug 28, 2009 at 1:42 PM, <pam@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> De-orange the layout tests: remove passing tests from the list and add
> PASS
> notation where needed.
>
> Haven't failed in 100+ builds:
>
> LINUX : LayoutTests/fast/history/back-forward-is-asynchronous.html
> LINUX : LayoutTests/fast/multicol/columns-shorthand-parsing.html
> MAC : LayoutTests/fast/css/only-of-type-pseudo-class.html
> MAC : LayoutTests/fast/events/pointer-events-2.html
> MAC : LayoutTests/fast/forms/listbox-onchange.html
> MAC : LayoutTests/fast/forms/listbox-selection.html
> MAC : LayoutTests/fast/forms/button-state-restore.html
> MAC : LayoutTests/fast/forms/input-type-change2.html
>
> Have been passing occasionally for at least 100 builds:
>
> LINUX :
>
> LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html
> LINUX :
>
> LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-prop.html
>
> Apparently fixed by r24625:
>
> MAC :
>
>
LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html
> MAC : LayoutTests/http/tests/security/cross-frame-access-protocol.html
> MAC :
> LayoutTests/http/tests/security/originHeader/origin-header-for-https.html
>
> Apparently fixed sometime before build 2930 (r24560):
> r24546-24548 MAC :
> LayoutTests/fast/history/back-forward-is-asynchronous.html
>
>
> BUG=5248, 18896, 19842, 20340, 20314
> TEST=covered by layout tests
>
>
> Please review this at http://codereview.chromium.org/173614
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 24772)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -1418,8 +1418,6 @@
>  BUG10355 WIN LINUX :
> LayoutTests/http/tests/security/originHeader/origin-header-for-empty.html =
> TIMEOUT FAIL PASS
>  BUG10355 MAC RELEASE :
> LayoutTests/http/tests/security/originHeader/origin-header-for-empty.html =
> TIMEOUT FAIL PASS
>
> -BUG10356 MAC :
> LayoutTests/http/tests/security/originHeader/origin-header-for-https.html =
> TIMEOUT FAIL
> -
>  // MERGE 38389:38450
>  // WebKit regression: https://bugs.webkit.org/show_bug.cgi?id=20342
>  // Fails upstream, deferring for now.
> @@ -1481,8 +1479,6 @@
>  BUG10368 MAC LINUX :
> LayoutTests/http/tests/navigation/lockedhistory-iframe.html = FAIL PASS
>
>  // selection
> -BUG10369 MAC : LayoutTests/fast/forms/listbox-onchange.html = FAIL
> -BUG10369 MAC : LayoutTests/fast/forms/listbox-selection.html = FAIL
>  BUG10369 MAC : LayoutTests/editing/selection/5109817.html = FAIL
>  BUG10369 LINUX : LayoutTests/editing/selection/5354455-2.html = FAIL
>
> @@ -1782,10 +1778,6 @@
>  BUG10430 LINUX : LayoutTests/svg/text/text-fonts-01-t.svg = FAIL
>  BUG10430 LINUX : LayoutTests/svg/text/text-intro-05-t.svg = FAIL
>
> -// Always fails for mac, new failure with merge for eseidel
> -BUG5248 MAC :
>
LayoutTests/http/tests/security/cross-frame-access-protocol-explicit-domain.html
> = FAIL
> -BUG5248 MAC :
> LayoutTests/http/tests/security/cross-frame-access-protocol.html = FAIL
> -
>  // New tests from merge 41181:41217
>  BUG10431 LINUX WIN :
>
LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
> = FAIL PASS
>
> @@ -2640,9 +2632,9 @@
>  BUG18896 WIN DEBUG : LayoutTests/fast/backgrounds/svg-as-background-5.html
> = FAIL
>  BUG18896 WIN LINUX DEBUG : LayoutTests/svg/batik/paints/gradientLimit.svg
> = FAIL
>  BUG18896 WIN DEBUG : LayoutTests/svg/carto.net/window.svg = FAIL
> -BUG18896 LINUX DEBUG :
> LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html
> = FAIL
> +BUG18896 LINUX DEBUG :
> LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html
> = PASS FAIL
>  BUG18896 MAC WIN DEBUG :
> LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html
> = PASS CRASH
> -BUG18896 LINUX DEBUG :
>
LayoutTests/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop.html
> = FAIL
> +BUG18896 LINUX DEBUG :
>
LayoutTests/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop.html
> = PASS FAIL
>  BUG18896 LINUX DEBUG :
> LayoutTests/svg/css/crash-css-generated-content.xhtml = FAIL
>
>  // Test failures from WebKit merge 46894 to 46977
> @@ -2681,8 +2673,6 @@
>  // Fallout from webkit 47305:47383
>  BUG19655 :
>
LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
> = FAIL
>  BUG19655 :
>
LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
> = FAIL
> -BUG_JPARENT LINUX MAC:
> LayoutTests/fast/history/back-forward-is-asynchronous.html = TIMEOUT
> -BUG_JPARENT LINUX DEBUG :
> LayoutTests/fast/multicol/columns-shorthand-parsing.html = CRASH
>
>  // WebKit roll r47417:47528
>  BUG19766 WIN : LayoutTests/svg/batik/text/textPosition.svg = FAIL
> @@ -2695,12 +2685,6 @@
>  BUG19665 MAC :
>
LayoutTests/platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress.html
> = FAIL
>  BUG19665 MAC :
>
LayoutTests/platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline.html
> = FAIL
>
> -// Temporary supression while we investigate.
> -BUG19842 MAC : LayoutTests/fast/forms/input-type-change2.html = CRASH
> -
> -// WebKit 47646:47719.
> -BUG20340 MAC : LayoutTests/fast/forms/button-state-restore.html = CRASH
> -
>  // WebKit 47719:47732. New test. Time out on all 3 platforms.
>  BUG20341 : LayoutTests/loader/go-back-to-different-window-size.html =
> TIMEOUT
>
> @@ -2714,9 +2698,6 @@
>  BUG20265 LINUX : LayoutTests/fast/forms/range-reset.html = CRASH
>  BUG20265 LINUX :
> LayoutTests/platform/mac/accessibility/slider-supports-actions.html = CRASH
>
> -// Fails after V8 rollup
> -BUG20314 MAC : LayoutTests/fast/css/only-of-type-pseudo-class.html = FAIL
> -
>  // WebKit 47777:47790 - getOwnPropertyDescriptor
>  BUG20345 : LayoutTests/fast/js/getOwnPropertyDescriptor.html = FAIL
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698