Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1736133002: Remove FDE_USEFORMATBLOCK. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FDE_USEFORMATBLOCK. This does not appear to ever be defined. There are a few methods which end up being empty after this change, removed those and their callers as well. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/198362223d2257ded96895bd91df2bea422f361e

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2211 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtengine.h View 1 chunk +0 lines, -11 lines 0 comments Download
D xfa/src/fee/src/fee/fde_txtedtblock.h View 1 chunk +0 lines, -239 lines 0 comments Download
D xfa/src/fee/src/fee/fde_txtedtblock.cpp View 1 chunk +0 lines, -676 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtbuf.h View 2 chunks +0 lines, -8 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtbuf.cpp View 2 chunks +1 line, -37 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.h View 5 chunks +1 line, -128 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.cpp View 18 chunks +5 lines, -1093 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/edit.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL
4 years, 10 months ago (2016-02-25 22:04:30 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-25 22:18:36 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-25 22:20:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
198362223d2257ded96895bd91df2bea422f361e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698