Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1736103002: MD Settings: remove .settings-card to make spacing more consistent (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove .settings-card to make spacing more consistent After lengthy conversations with bettes@, it seems more consistent to simply remove the extra top/bottom padding that settings-card added. It looked better in some cases, but generally gave us more headaches than it alleviated. R=dschuyler@chromium.org BUG=589630 Committed: https://crrev.com/287837b73f873871b28df447528fc6fbadc06f20 Cr-Commit-Position: refs/heads/master@{#377985}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : based on --google/paper colors #

Messages

Total messages: 17 (10 generated)
Dan Beam
4 years, 10 months ago (2016-02-25 21:19:09 UTC) #2
dschuyler
lgtm
4 years, 10 months ago (2016-02-25 21:21:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736103002/40001
4 years, 10 months ago (2016-02-26 20:12:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/99536)
4 years, 10 months ago (2016-02-26 20:41:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736103002/40001
4 years, 10 months ago (2016-02-26 21:08:06 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 21:42:17 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:44:47 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/287837b73f873871b28df447528fc6fbadc06f20
Cr-Commit-Position: refs/heads/master@{#377985}

Powered by Google App Engine
This is Rietveld 408576698