Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: cc/layers/layer_impl_unittest.cc

Issue 1736073002: cc: Move SyncedScrollOffset to scroll tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/layer_impl.h" 5 #include "cc/layers/layer_impl.h"
6 6
7 #include "cc/animation/mutable_properties.h" 7 #include "cc/animation/mutable_properties.h"
8 #include "cc/layers/painted_scrollbar_layer_impl.h" 8 #include "cc/layers/painted_scrollbar_layer_impl.h"
9 #include "cc/layers/solid_color_scrollbar_layer_impl.h" 9 #include "cc/layers/solid_color_scrollbar_layer_impl.h"
10 #include "cc/output/filter_operation.h" 10 #include "cc/output/filter_operation.h"
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset()); 551 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset());
552 } 552 }
553 553
554 TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) { 554 TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) {
555 gfx::ScrollOffset scroll_offset(10, 5); 555 gfx::ScrollOffset scroll_offset(10, 5);
556 gfx::Vector2dF scroll_delta(20.5f, 8.5f); 556 gfx::Vector2dF scroll_delta(20.5f, 8.5f);
557 gfx::Vector2d sent_scroll_delta(12, -3); 557 gfx::Vector2d sent_scroll_delta(12, -3);
558 558
559 layer()->PushScrollOffsetFromMainThread(scroll_offset); 559 layer()->PushScrollOffsetFromMainThread(scroll_offset);
560 layer()->ScrollBy(sent_scroll_delta); 560 layer()->ScrollBy(sent_scroll_delta);
561 layer()->PullDeltaForMainThread(); 561 layer()->synced_scroll_offset()->PullDeltaForMainThread();
562 layer()->SetCurrentScrollOffset(scroll_offset + 562 layer()->SetCurrentScrollOffset(scroll_offset +
563 gfx::ScrollOffset(scroll_delta)); 563 gfx::ScrollOffset(scroll_delta));
564 564
565 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta), 565 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta),
566 layer()->CurrentScrollOffset()); 566 layer()->CurrentScrollOffset());
567 EXPECT_VECTOR_EQ(scroll_delta, layer()->ScrollDelta()); 567 EXPECT_VECTOR_EQ(scroll_delta, layer()->ScrollDelta());
568 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset()); 568 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset());
569 569
570 layer()->ApplySentScrollDeltasFromAbortedCommit(); 570 layer()->synced_scroll_offset()->AbortCommit();
571 571
572 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta), 572 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta),
573 layer()->CurrentScrollOffset()); 573 layer()->CurrentScrollOffset());
574 EXPECT_VECTOR_EQ(scroll_delta - sent_scroll_delta, layer()->ScrollDelta()); 574 EXPECT_VECTOR_EQ(scroll_delta - sent_scroll_delta, layer()->ScrollDelta());
575 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, sent_scroll_delta), 575 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, sent_scroll_delta),
576 layer()->BaseScrollOffset()); 576 layer()->BaseScrollOffset());
577 } 577 }
578 578
579 TEST_F(LayerImplScrollTest, ScrollUserUnscrollableLayer) { 579 TEST_F(LayerImplScrollTest, ScrollUserUnscrollableLayer) {
580 gfx::ScrollOffset scroll_offset(10, 5); 580 gfx::ScrollOffset scroll_offset(10, 5);
(...skipping 12 matching lines...) Expand all
593 gfx::Vector2dF scroll_delta(12, 18); 593 gfx::Vector2dF scroll_delta(12, 18);
594 594
595 host_impl().CreatePendingTree(); 595 host_impl().CreatePendingTree();
596 596
597 layer()->PushScrollOffsetFromMainThread(scroll_offset); 597 layer()->PushScrollOffsetFromMainThread(scroll_offset);
598 gfx::Vector2dF unscrolled = layer()->ScrollBy(scroll_delta); 598 gfx::Vector2dF unscrolled = layer()->ScrollBy(scroll_delta);
599 599
600 EXPECT_VECTOR_EQ(gfx::Vector2dF(0, 0), unscrolled); 600 EXPECT_VECTOR_EQ(gfx::Vector2dF(0, 0), unscrolled);
601 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset()); 601 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset());
602 602
603 layer()->PullDeltaForMainThread(); 603 layer()->synced_scroll_offset()->PullDeltaForMainThread();
604 604
605 scoped_ptr<LayerImpl> pending_layer = LayerImpl::Create( 605 scoped_ptr<LayerImpl> pending_layer = LayerImpl::Create(
606 host_impl().sync_tree(), layer()->id(), layer()->synced_scroll_offset()); 606 host_impl().sync_tree(), layer()->id(), layer()->synced_scroll_offset());
607 pending_layer->PushScrollOffsetFromMainThread(layer()->CurrentScrollOffset()); 607 pending_layer->PushScrollOffsetFromMainThread(layer()->CurrentScrollOffset());
608 608
609 pending_layer->PushPropertiesTo(layer()); 609 pending_layer->PushPropertiesTo(layer());
610 610
611 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset()); 611 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset());
612 EXPECT_VECTOR_EQ(layer()->CurrentScrollOffset(), 612 EXPECT_VECTOR_EQ(layer()->CurrentScrollOffset(),
613 pending_layer->CurrentScrollOffset()); 613 pending_layer->CurrentScrollOffset());
614 } 614 }
615 615
616 } // namespace 616 } // namespace
617 } // namespace cc 617 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698